You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/03/23 21:24:20 UTC
Review Request 66261: [ATLAS-2514]: Deleting a table with lineage
should not remove propagated classification edges
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66261/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2514
https://issues.apache.org/jira/browse/ATLAS-2514
Repository: atlas
Description
-------
When a table with tag assigned is deleted, the propagated classification edges to the downstream entities should not be removed.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 18ed533d
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 49c9e0ca
Diff: https://reviews.apache.org/r/66261/diff/1/
Testing
-------
Thanks,
Sarath Subramanian
Re: Review Request 66261: [ATLAS-2514]: Deleting a table with lineage
should not remove propagated classification edges
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66261/#review199987
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 26, 2018, 4:18 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66261/
> -----------------------------------------------------------
>
> (Updated March 26, 2018, 4:18 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2514
> https://issues.apache.org/jira/browse/ATLAS-2514
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When a table with tag assigned is deleted, the propagated classification edges to the downstream entities should not be removed.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 9e8077cb
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 18ed533d
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 49c9e0ca
>
>
> Diff: https://reviews.apache.org/r/66261/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 66261: [ATLAS-2514]: Deleting a table with lineage
should not remove propagated classification edges
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66261/
-----------------------------------------------------------
(Updated March 26, 2018, 9:18 a.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Changes
-------
addressed review comments from Madhan.
Bugs: ATLAS-2514
https://issues.apache.org/jira/browse/ATLAS-2514
Repository: atlas
Description
-------
When a table with tag assigned is deleted, the propagated classification edges to the downstream entities should not be removed.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 9e8077cb
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 18ed533d
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 49c9e0ca
Diff: https://reviews.apache.org/r/66261/diff/2/
Changes: https://reviews.apache.org/r/66261/diff/1-2/
Testing
-------
Thanks,
Sarath Subramanian
Re: Review Request 66261: [ATLAS-2514]: Deleting a table with lineage
should not remove propagated classification edges
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66261/#review199921
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
Line 500 (original), 498 (patched)
<https://reviews.apache.org/r/66261/#comment280431>
Getting classificationNames above (line #492) would have iterated through edges named as 'classifiedAs'. The same edges are retrieved again in the 'for' loop below (like #499). Consider adding a method "List<AtlasEdge> getClassificationEdges(entityVertex)" and use the returned edges in following "for" loop.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
Lines 693 (patched)
<https://reviews.apache.org/r/66261/#comment280430>
instanceVertex => classificationVertex
- Madhan Neethiraj
On March 23, 2018, 9:24 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66261/
> -----------------------------------------------------------
>
> (Updated March 23, 2018, 9:24 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2514
> https://issues.apache.org/jira/browse/ATLAS-2514
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When a table with tag assigned is deleted, the propagated classification edges to the downstream entities should not be removed.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 18ed533d
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 49c9e0ca
>
>
> Diff: https://reviews.apache.org/r/66261/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sarath Subramanian
>
>