You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by "bdoyle0182 (via GitHub)" <gi...@apache.org> on 2023/03/28 23:36:33 UTC
[GitHub] [openwhisk] bdoyle0182 opened a new pull request, #5389: update kryo and use compatibility serializer for future message forma…
bdoyle0182 opened a new pull request, #5389:
URL: https://github.com/apache/openwhisk/pull/5389
## Description
To support future changes to the akka serialized messages that use kryo, we need to use kryo compatibility serializer i.e. to support the max instances pr.
This is a breaking change if trying to rolling upgrade an existing cluster creating new action queues between the scheduler and controller.
If you are not using the new scheduler architecture, this change is completely non-impacting. If you are using the new scheduler architecture, you can either do a blue / green deployment with a new cluster to upgrade or if you must do a rolling upgrade of an existing cluster; you can upgrade the controllers first such that only things that will return 503 during the deployment window are new actions that have not been running, live running queues in the scheduler would continue to be able to take activations.
Since this is a one time breaking serialization change to the scheduler, I've also taken the opportunity to perform the major version akka-kryo upgrade to handle cve's for kryo 4.
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
- [ ] API
- [X] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [X] Scheduler
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [ ] Enhancement or new feature (adds new functionality).
- [X] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
- [X] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [X] I reviewed the [style guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] bdoyle0182 merged pull request #5389: use compatibility serializer for future message forma…
Posted by "bdoyle0182 (via GitHub)" <gi...@apache.org>.
bdoyle0182 merged PR #5389:
URL: https://github.com/apache/openwhisk/pull/5389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on pull request #5389: use compatibility serializer for future message forma…
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 commented on PR #5389:
URL: https://github.com/apache/openwhisk/pull/5389#issuecomment-1491146187
Do we need to send a notice about the breaking change via the dev mailing list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-commenter commented on pull request #5389: use compatibility serializer for future message forma…
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5389:
URL: https://github.com/apache/openwhisk/pull/5389#issuecomment-1487781364
## [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5389?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#5389](https://codecov.io/gh/apache/openwhisk/pull/5389?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab0bde2) into [master](https://codecov.io/gh/apache/openwhisk/commit/60ca6605bb081f99906cff1a21caf75d47e414fa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (60ca660) will **decrease** coverage by `72.48%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head ab0bde2 differs from pull request most recent head 48abf07. Consider uploading reports for the commit 48abf07 to get more accurate results
```diff
@@ Coverage Diff @@
## master #5389 +/- ##
==========================================
- Coverage 76.91% 4.44% -72.48%
==========================================
Files 240 240
Lines 14588 14589 +1
Branches 629 630 +1
==========================================
- Hits 11221 648 -10573
- Misses 3367 13941 +10574
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/5389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/openwhisk/core/scheduler/Scheduler.scala](https://codecov.io/gh/apache/openwhisk/pull/5389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zY2hlZHVsZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9vcGVud2hpc2svY29yZS9zY2hlZHVsZXIvU2NoZWR1bGVyLnNjYWxh) | `0.00% <0.00%> (-10.83%)` | :arrow_down: |
... and [204 files with indirect coverage changes](https://codecov.io/gh/apache/openwhisk/pull/5389/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org