You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by "David Johnson (JIRA)" <ji...@apache.org> on 2010/08/12 00:10:17 UTC
[jira] Resolved: (ROL-1741) jndi prefix should not be used
[ https://issues.apache.org/jira/browse/ROL-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Johnson resolved ROL-1741.
--------------------------------
Resolution: Fixed
Author: snoopdave
Date: Wed Aug 11 21:57:18 2010
New Revision: 984600
URL: http://svn.apache.org/viewvc?rev=984600&view=rev
Log:
Fix for https://issues.apache.org/jira/browse/ROL-1741
Don't attempt to build JNDI name if one is already specified. Check for presence of ":" to determine if full name already specified.
Modified:
roller/trunk/weblogger-business/src/main/java/org/apache/roller/weblogger/business/DatabaseProvider.java
> jndi prefix should not be used
> ------------------------------
>
> Key: ROL-1741
> URL: https://issues.apache.org/jira/browse/ROL-1741
> Project: Roller
> Issue Type: Bug
> Components: Database Access & Data Model
> Affects Versions: 4.0
> Environment: solaris within jboss container
> Reporter: Mike Jackson
> Assignee: Dave Johnson
> Fix For: 5.0
>
>
> On line 124 of org.apache.roller.weblogger.business.DatabaserProvider is prefixed with "java:comp/env/". May or may not work for all containers and will definately lead to frustration on the part of the installer expecting to have to supply the "java:" part of the JNDI url. JBoss for instance tends to put datasources at "java:/<datasource name>". If it were up to me I'd re-write that line as follows:
> String name = ( getJndiName().indexOf(":") == -1 ? "java:comp/env/" + getJndiName() : getJndiName());
> This assumes that a value JNDI lookup will always have a ":" in it. This is probably a safe bet.
> <sandbox>It'd be nice if there was a document out there that went through all of the options available to be configured via the roller-custom.properties file, such as this one. The install guide is really sparse in this regard.</sandbox>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.