You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "amoeba (via GitHub)" <gi...@apache.org> on 2025/05/31 00:55:43 UTC
[PR] GH-46652: [Python][Docs] Update language for row_group_size parameter [arrow]
amoeba opened a new pull request, #46653:
URL: https://github.com/apache/arrow/pull/46653
### Rationale for this change
The docstrings for row_group_size could be clearer both in terms of (1) whether the value is rows instead of byte size and (2) use of unit prefixes. See https://github.com/apache/arrow/issues/46652.
My idea here was that just saying "64 * 1024 * 1024" is probably more easily understood than using Mi (mebi).
### What changes are included in this PR?
- Updated language in docstrings for row_group_size
- Add missing `, default None` to docstring for top-level `write_table`
### Are these changes tested?
No.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46652: [Python][Docs] Update language for row_group_size parameter [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #46653:
URL: https://github.com/apache/arrow/pull/46653#issuecomment-2923932764
I think the two current CI failures are unrelated. `archery lint --python` locally shows some issues but none for the affected code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46652: [Python][Docs] Update language for row_group_size parameter [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46653:
URL: https://github.com/apache/arrow/pull/46653#issuecomment-2942717562
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 832bfa1ec67c3a6d43dab5abe7d84271680fee9c.
There were 72 benchmark results with an error:
- Commit Run on `amd64-m5-4xlarge-linux` at [2025-06-04 12:26:22Z](https://conbench.ursa.dev/compare/runs/73df310bc8e54fb6ac2729b6e92ebb42...267faad86e3343a3aaa6c390eec0d2f0/)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-04, scale_factor=10](https://conbench.ursa.dev/benchmark-results/0684061a06d57d0180009cd158b9f80d)
- [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-12, scale_factor=1](https://conbench.ursa.dev/benchmark-results/068407c3a3237a1380005ff42795c9f3)
- and 70 more (see the report linked below)
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/43515253289) has more details. It also includes information about 42 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46652: [Python][Docs] Update language for row_group_size parameter [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46653:
URL: https://github.com/apache/arrow/pull/46653#issuecomment-2923850421
:warning: GitHub issue #46652 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46652: [Python][Docs] Update language for row_group_size parameter [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #46653:
URL: https://github.com/apache/arrow/pull/46653#issuecomment-2941012205
Thanks @AlenkaF @pitrou.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46652: [Python][Docs] Update language for row_group_size parameter [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46653:
URL: https://github.com/apache/arrow/pull/46653#issuecomment-2924315048
:warning: GitHub issue #46652 **has no components**, please add labels for components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46652: [Python][Docs] Update language for row_group_size parameter [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46653:
URL: https://github.com/apache/arrow/pull/46653#issuecomment-2923850423
:warning: GitHub issue #46652 **has no components**, please add labels for components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46652: [Python][Docs] Update language for row_group_size parameter [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF merged PR #46653:
URL: https://github.com/apache/arrow/pull/46653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org