You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/05/22 13:46:18 UTC

[GitHub] brooklyn-server pull request #691: Fix generics usage (for compilation in Ec...

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/691

    Fix generics usage (for compilation in Eclipse)

    Fixes generics compilation errors that the Eclipse compiler reports, with Java 8 (in Eclipse 4.6.3).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server generics-usage-for-eclipse-compiler

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/691.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #691
    
----
commit 1eb1a0b48dd09d843a511f1da35f344ecaaa3354
Author: Aled Sage <al...@gmail.com>
Date:   2017-05-22T13:04:30Z

    Fix generics usage (for compilation in Eclipse)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #691: Fix generics usage (for compilation in Eclipse)

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/691
  
    Thanks @geomacy - I've deleted that comment. Merging now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #691: Fix generics usage (for compilation in Ec...

Posted by geomacy <gi...@git.apache.org>.

Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/691#discussion_r117753350
  
    --- Diff: core/src/test/java/org/apache/brooklyn/core/network/OnPublicNetworkEnricherTest.java ---
    @@ -372,7 +371,7 @@ public void testIgnoresWithNoPort() throws Exception {
             
             // Ugly casting in java, but easy to get passed this when constructed from YAML
    --- End diff --
    
    don't need this comment any more?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #691: Fix generics usage (for compilation in Ec...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/691


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---