[GitHub] [hive] zabetak commented on a diff in pull request #4101: HIVE-27124: Temporarily disable adding AntiJoin to plans by default.

["zabetak (via GitHub)" <gi...@apache.org>]

zabetak commented on code in PR #4101:
URL: https://github.com/apache/hive/pull/4101#discussion_r1131200440


##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2366,7 +2366,7 @@ public static enum ConfVars {
         "Whether Hive enables the optimization about converting common join into mapjoin based on the input file size. \n" +
         "If this parameter is on, and the sum of size for n-1 of the tables/partitions for a n-way join is smaller than the\n" +
         "specified size, the join is directly converted to a mapjoin (there is no conditional task)."),
-    HIVE_CONVERT_ANTI_JOIN("hive.auto.convert.anti.join", true,
+    HIVE_CONVERT_ANTI_JOIN("hive.auto.convert.anti.join", false,
         "Whether Hive enables the optimization about converting join with null filter to anti join"),

Review Comment:
   I would also add a small warning in the description that turning it to `true` may in some cases lead to wrong results or that at this stage it is an experimental feature or something along these lines. Without doing so users do not know if they should touch the configs or not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org