You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Lucas Brutschy (Jira)" <ji...@apache.org> on 2024/02/19 09:20:00 UTC

[jira] [Assigned] (KAFKA-15913) Migrate AsyncKafkaConsumerTest away from ConsumerTestBuilder

     [ https://issues.apache.org/jira/browse/KAFKA-15913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lucas Brutschy reassigned KAFKA-15913:
--------------------------------------

    Assignee: Lucas Brutschy  (was: Lucas Brutschy)

> Migrate AsyncKafkaConsumerTest away from ConsumerTestBuilder
> ------------------------------------------------------------
>
>                 Key: KAFKA-15913
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15913
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: clients, consumer
>            Reporter: Philip Nee
>            Assignee: Lucas Brutschy
>            Priority: Major
>              Labels: consumer-threading-refactor
>             Fix For: 3.7.0
>
>
> ConsumerTestBuilder is meant to be an unit testing utility; however, we seem to use Mockito#spy quite liberally.  This is not the right testing strategy because we basically turn unit testing into integration testing.
>  
> While the current unit tests run fine, we should probably make the mocking using Mockito#mock by default and test each dependency independently.
>  
> The ask here is
>  # Make mock(class) by default
>  # Provide more flexible interface for the testBuilder to allow user to configure spy or mock.  Or, let user pass in their own mock.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)