You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by pa...@apache.org on 2022/11/24 07:42:07 UTC
[shardingsphere] branch master updated: Add final for test cases' list fields (#22381)
This is an automated email from the ASF dual-hosted git repository.
panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 443899a9a09 Add final for test cases' list fields (#22381)
443899a9a09 is described below
commit 443899a9a09daf6ac74026a0794c61c8d51d22c6
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Thu Nov 24 15:42:00 2022 +0800
Add final for test cases' list fields (#22381)
---
.../internal/asserts/segment/assignment/AssignmentAssert.java | 2 +-
.../parser/internal/asserts/segment/distsql/DataSourceAssert.java | 8 ++++----
.../parser/internal/asserts/segment/distsql/PropertiesAssert.java | 2 +-
.../internal/asserts/segment/distsql/rdl/EncryptRuleAssert.java | 7 ++++---
.../parser/domain/segment/impl/assignment/ExpectedAssignment.java | 3 ++-
.../segment/impl/definition/ExpectedConstraintDefinition.java | 4 ++--
.../parser/domain/segment/impl/distsql/ExpectedAlgorithm.java | 3 ++-
.../parser/domain/segment/impl/distsql/ExpectedDataSource.java | 3 ++-
.../segment/impl/distsql/rdl/ExceptedReadwriteSplittingRule.java | 3 ++-
.../impl/distsql/rdl/ExpectedDatabaseDiscoveryDefinitionRule.java | 3 ++-
.../impl/distsql/rdl/ExpectedDatabaseDiscoveryHeartbeat.java | 3 ++-
.../domain/segment/impl/distsql/rdl/ExpectedEncryptRule.java | 3 ++-
.../domain/segment/impl/expr/ExpectedCaseWhenExpression.java | 4 ++--
.../parser/domain/segment/impl/function/ExpectedFunction.java | 2 +-
.../parser/domain/segment/impl/index/ExpectedCacheTableIndex.java | 2 +-
.../parser/domain/segment/impl/index/ExpectedLoadTableIndex.java | 4 ++--
.../cases/parser/domain/segment/impl/with/ExpectedWithClause.java | 4 +---
.../parser/domain/statement/ddl/CreateIndexStatementTestCase.java | 2 +-
.../cases/parser/domain/statement/dml/CopyStatementTestCase.java | 2 +-
.../ral/migration/ShowMigrationStatusStatementTestCase.java | 3 ++-
20 files changed, 37 insertions(+), 30 deletions(-)
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/assignment/AssignmentAssert.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/assignment/AssignmentAssert.java
index 3603bd9380d..3a4f20669db 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/assignment/AssignmentAssert.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/assignment/AssignmentAssert.java
@@ -42,7 +42,7 @@ public final class AssignmentAssert {
* @param expected expected assignment
*/
public static void assertIs(final SQLCaseAssertContext assertContext, final AssignmentSegment actual, final ExpectedAssignment expected) {
- if (null == expected.getColumns()) {
+ if (expected.getColumns().isEmpty()) {
ColumnAssert.assertIs(assertContext, actual.getColumns().get(0), expected.getColumn());
} else {
assertThat(assertContext.getText("Assignment columns size assertion error: "), actual.getColumns().size(), is(expected.getColumns().size()));
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/distsql/DataSourceAssert.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/distsql/DataSourceAssert.java
index 7c459d0ba1d..988136a0f2a 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/distsql/DataSourceAssert.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/distsql/DataSourceAssert.java
@@ -53,13 +53,13 @@ public final class DataSourceAssert {
assertThat(assertContext.getText(String.format("`%s`'s datasource segment assertion error: ", actual.getClass().getSimpleName())), actual.getPassword(), is(expected.getPassword()));
PropertiesAssert.assertIs(assertContext, actual.getProps(), expected.getProperties());
if (actual instanceof URLBasedDataSourceSegment) {
- assertThat(assertContext.getText(String.format("`%s`'s datasource segment assertion error: ",
- actual.getClass().getSimpleName())), ((URLBasedDataSourceSegment) actual).getUrl(), is(expected.getUrl()));
+ assertThat(assertContext.getText(String.format("`%s`'s datasource segment assertion error: ", actual.getClass().getSimpleName())), ((URLBasedDataSourceSegment) actual).getUrl(),
+ is(expected.getUrl()));
}
if (actual instanceof HostnameAndPortBasedDataSourceSegment) {
HostnameAndPortBasedDataSourceSegment actualSegment = (HostnameAndPortBasedDataSourceSegment) actual;
- assertThat(assertContext.getText(String.format("`%s`'s datasource segment assertion error: ",
- actual.getClass().getSimpleName())), actualSegment.getHostname(), is(expected.getHostname()));
+ assertThat(assertContext.getText(String.format("`%s`'s datasource segment assertion error: ", actual.getClass().getSimpleName())), actualSegment.getHostname(),
+ is(expected.getHostname()));
assertThat(assertContext.getText(String.format("`%s`'s datasource segment assertion error: ", actual.getClass().getSimpleName())), actualSegment.getPort(), is(expected.getPort()));
assertThat(assertContext.getText(String.format("`%s`'s datasource segment assertion error: ", actual.getClass().getSimpleName())), actualSegment.getDatabase(), is(expected.getDb()));
}
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/distsql/PropertiesAssert.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/distsql/PropertiesAssert.java
index 582585f5264..f520cce0485 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/distsql/PropertiesAssert.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/distsql/PropertiesAssert.java
@@ -42,7 +42,7 @@ public final class PropertiesAssert {
* @param expected expected properties test case
*/
public static void assertIs(final SQLCaseAssertContext assertContext, final Properties actual, final List<ExpectedProperty> expected) {
- if (null == expected) {
+ if (expected.isEmpty()) {
assertTrue(assertContext.getText("Actual properties should not exist."), actual.isEmpty());
} else {
assertNotNull(assertContext.getText("Actual properties should exist."), actual);
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/distsql/rdl/EncryptRuleAssert.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/distsql/rdl/EncryptRuleAssert.java
index 80a3595670e..b56652fa941 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/distsql/rdl/EncryptRuleAssert.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/segment/distsql/rdl/EncryptRuleAssert.java
@@ -29,6 +29,7 @@ import java.util.Collection;
import java.util.List;
import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.hamcrest.MatcherAssert.assertThat;
@@ -58,11 +59,11 @@ public final class EncryptRuleAssert {
}
private static void assertEncryptColumns(final SQLCaseAssertContext assertContext, final Collection<EncryptColumnSegment> actual, final List<ExpectedEncryptColumn> expected) {
- if (null == expected) {
+ if (expected.isEmpty()) {
assertNull(assertContext.getText("Actual encrypt column should not exist."), actual);
} else {
- assertNotNull(assertContext.getText("Actual encrypt column should exist."), actual);
- assertThat(assertContext.getText(String.format("Actual encrypt column size should be %s , but it was %s", expected.size(), actual.size())), actual.size(), is(expected.size()));
+ assertFalse(assertContext.getText("Actual encrypt column should exist."), actual.isEmpty());
+ assertThat(assertContext.getText(String.format("Actual encrypt column size should be %s, but it was %s.", expected.size(), actual.size())), actual.size(), is(expected.size()));
int count = 0;
for (EncryptColumnSegment encryptColumnSegment : actual) {
ExpectedEncryptColumn expectedEncryptColumn = expected.get(count);
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/assignment/ExpectedAssignment.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/assignment/ExpectedAssignment.java
index 3a2b4a496c2..71de1dbf82e 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/assignment/ExpectedAssignment.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/assignment/ExpectedAssignment.java
@@ -23,6 +23,7 @@ import org.apache.shardingsphere.test.sql.parser.internal.cases.parser.domain.se
import org.apache.shardingsphere.test.sql.parser.internal.cases.parser.domain.segment.impl.column.ExpectedColumn;
import javax.xml.bind.annotation.XmlElement;
+import java.util.LinkedList;
import java.util.List;
/**
@@ -36,7 +37,7 @@ public final class ExpectedAssignment extends AbstractExpectedSQLSegment {
private ExpectedColumn column;
@XmlElement
- private List<ExpectedColumn> columns;
+ private final List<ExpectedColumn> columns = new LinkedList<>();
@XmlElement(name = "assignment-value")
private ExpectedAssignmentValue assignmentValue;
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/definition/ExpectedConstraintDefinition.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/definition/ExpectedConstraintDefinition.java
index 79ae8a8d10f..e103abade96 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/definition/ExpectedConstraintDefinition.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/definition/ExpectedConstraintDefinition.java
@@ -39,10 +39,10 @@ public final class ExpectedConstraintDefinition extends AbstractExpectedSQLSegme
private ExpectedSimpleTable referencedTable;
@XmlElement(name = "primary-key-column")
- private List<ExpectedColumn> primaryKeyColumns = new LinkedList<>();
+ private final List<ExpectedColumn> primaryKeyColumns = new LinkedList<>();
@XmlElement(name = "index-column")
- private List<ExpectedColumn> indexColumns = new LinkedList<>();
+ private final List<ExpectedColumn> indexColumns = new LinkedList<>();
@XmlAttribute(name = "constraint-name")
private String constraintName;
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/ExpectedAlgorithm.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/ExpectedAlgorithm.java
index ec038e46f57..ae8f40471aa 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/ExpectedAlgorithm.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/ExpectedAlgorithm.java
@@ -23,6 +23,7 @@ import org.apache.shardingsphere.test.sql.parser.internal.cases.parser.domain.se
import javax.xml.bind.annotation.XmlAttribute;
import javax.xml.bind.annotation.XmlElement;
+import java.util.LinkedList;
import java.util.List;
/**
@@ -36,5 +37,5 @@ public final class ExpectedAlgorithm extends AbstractExpectedIdentifierSQLSegmen
private String name;
@XmlElement(name = "property")
- private List<ExpectedProperty> properties;
+ private final List<ExpectedProperty> properties = new LinkedList<>();
}
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/ExpectedDataSource.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/ExpectedDataSource.java
index a6b1783fe47..45baa10a739 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/ExpectedDataSource.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/ExpectedDataSource.java
@@ -23,6 +23,7 @@ import org.apache.shardingsphere.test.sql.parser.internal.cases.parser.domain.se
import javax.xml.bind.annotation.XmlAttribute;
import javax.xml.bind.annotation.XmlElement;
+import java.util.LinkedList;
import java.util.List;
/**
@@ -51,5 +52,5 @@ public final class ExpectedDataSource extends AbstractExpectedIdentifierSQLSegme
private String password;
@XmlElement(name = "property")
- private List<ExpectedProperty> properties;
+ private final List<ExpectedProperty> properties = new LinkedList<>();
}
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExceptedReadwriteSplittingRule.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExceptedReadwriteSplittingRule.java
index 684fff77606..80d51cf6ebb 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExceptedReadwriteSplittingRule.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExceptedReadwriteSplittingRule.java
@@ -24,6 +24,7 @@ import org.apache.shardingsphere.test.sql.parser.internal.cases.parser.domain.se
import javax.xml.bind.annotation.XmlAttribute;
import javax.xml.bind.annotation.XmlElement;
+import java.util.LinkedList;
import java.util.List;
/**
@@ -46,5 +47,5 @@ public final class ExceptedReadwriteSplittingRule extends AbstractExpectedIdenti
private String loadBalancer;
@XmlElement(name = "property")
- private List<ExpectedProperty> properties;
+ private final List<ExpectedProperty> properties = new LinkedList<>();
}
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExpectedDatabaseDiscoveryDefinitionRule.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExpectedDatabaseDiscoveryDefinitionRule.java
index 9f36bfe550d..e4d5c8474e6 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExpectedDatabaseDiscoveryDefinitionRule.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExpectedDatabaseDiscoveryDefinitionRule.java
@@ -26,6 +26,7 @@ import org.apache.shardingsphere.test.sql.parser.internal.cases.parser.domain.se
import javax.xml.bind.annotation.XmlAttribute;
import javax.xml.bind.annotation.XmlElement;
import java.util.Collection;
+import java.util.LinkedList;
import java.util.List;
/**
@@ -45,5 +46,5 @@ public final class ExpectedDatabaseDiscoveryDefinitionRule extends AbstractExpec
private ExpectedAlgorithm discoveryType;
@XmlElement(name = "property")
- private List<ExpectedProperty> properties;
+ private final List<ExpectedProperty> properties = new LinkedList<>();
}
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExpectedDatabaseDiscoveryHeartbeat.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExpectedDatabaseDiscoveryHeartbeat.java
index 84b81551a68..2f8529b77b1 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExpectedDatabaseDiscoveryHeartbeat.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExpectedDatabaseDiscoveryHeartbeat.java
@@ -24,6 +24,7 @@ import org.apache.shardingsphere.test.sql.parser.internal.cases.parser.domain.se
import javax.xml.bind.annotation.XmlAttribute;
import javax.xml.bind.annotation.XmlElement;
+import java.util.LinkedList;
import java.util.List;
/**
@@ -37,5 +38,5 @@ public final class ExpectedDatabaseDiscoveryHeartbeat extends AbstractExpectedId
private String name;
@XmlElement(name = "property")
- private List<ExpectedProperty> properties;
+ private final List<ExpectedProperty> properties = new LinkedList<>();
}
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExpectedEncryptRule.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExpectedEncryptRule.java
index f1a6fc28cc8..c1c06e96cdb 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExpectedEncryptRule.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/distsql/rdl/ExpectedEncryptRule.java
@@ -23,6 +23,7 @@ import org.apache.shardingsphere.test.sql.parser.internal.cases.parser.domain.se
import javax.xml.bind.annotation.XmlAttribute;
import javax.xml.bind.annotation.XmlElement;
+import java.util.LinkedList;
import java.util.List;
/**
@@ -33,7 +34,7 @@ import java.util.List;
public final class ExpectedEncryptRule extends AbstractExpectedIdentifierSQLSegment {
@XmlElement(name = "column")
- private List<ExpectedEncryptColumn> columns;
+ private final List<ExpectedEncryptColumn> columns = new LinkedList<>();
@XmlAttribute(name = "query-with-cipher-column")
private Boolean queryWithCipherColumn;
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/expr/ExpectedCaseWhenExpression.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/expr/ExpectedCaseWhenExpression.java
index 5774801b53f..b507ef1c73d 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/expr/ExpectedCaseWhenExpression.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/expr/ExpectedCaseWhenExpression.java
@@ -36,10 +36,10 @@ public final class ExpectedCaseWhenExpression extends AbstractExpectedSQLSegment
private ExpectedExpression caseArg;
@XmlElement(name = "when-list")
- private List<ExpectedExpression> whenList = new LinkedList<>();
+ private final List<ExpectedExpression> whenList = new LinkedList<>();
@XmlElement(name = "then-list")
- private List<ExpectedExpression> thenList = new LinkedList<>();
+ private final List<ExpectedExpression> thenList = new LinkedList<>();
@XmlElement(name = "else-expression")
private ExpectedExpression elseExpr;
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/function/ExpectedFunction.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/function/ExpectedFunction.java
index 3f1ccd604ed..e465a86b14a 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/function/ExpectedFunction.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/function/ExpectedFunction.java
@@ -40,7 +40,7 @@ public final class ExpectedFunction extends AbstractExpectedSQLSegment implement
private String functionName;
@XmlElement(name = "parameter")
- private List<ExpectedExpression> parameters = new LinkedList<>();
+ private final List<ExpectedExpression> parameters = new LinkedList<>();
@XmlAttribute
private String text;
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/index/ExpectedCacheTableIndex.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/index/ExpectedCacheTableIndex.java
index e22713c414a..463d1561180 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/index/ExpectedCacheTableIndex.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/index/ExpectedCacheTableIndex.java
@@ -37,5 +37,5 @@ public final class ExpectedCacheTableIndex extends AbstractExpectedIdentifierSQL
private ExpectedSimpleTable table;
@XmlElement(name = "index")
- private List<ExpectedIndex> indexNames = new LinkedList<>();
+ private final List<ExpectedIndex> indexNames = new LinkedList<>();
}
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/index/ExpectedLoadTableIndex.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/index/ExpectedLoadTableIndex.java
index 8f01acf40d4..ce5532523a6 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/index/ExpectedLoadTableIndex.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/index/ExpectedLoadTableIndex.java
@@ -37,8 +37,8 @@ public final class ExpectedLoadTableIndex extends AbstractExpectedIdentifierSQLS
private ExpectedSimpleTable table;
@XmlElement(name = "index")
- private List<ExpectedIndex> indexNames = new LinkedList<>();
+ private final List<ExpectedIndex> indexNames = new LinkedList<>();
@XmlElement(name = "partition")
- private List<ExpectedPartition> partitions = new LinkedList<>();
+ private final List<ExpectedPartition> partitions = new LinkedList<>();
}
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/with/ExpectedWithClause.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/with/ExpectedWithClause.java
index eefa2b515dd..a0cf2b42a0b 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/with/ExpectedWithClause.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/segment/impl/with/ExpectedWithClause.java
@@ -18,7 +18,6 @@
package org.apache.shardingsphere.test.sql.parser.internal.cases.parser.domain.segment.impl.with;
import lombok.Getter;
-import lombok.Setter;
import org.apache.shardingsphere.test.sql.parser.internal.cases.parser.domain.segment.AbstractExpectedSQLSegment;
import javax.xml.bind.annotation.XmlElement;
@@ -29,9 +28,8 @@ import java.util.List;
* Expected withs clause.
*/
@Getter
-@Setter
public final class ExpectedWithClause extends AbstractExpectedSQLSegment {
@XmlElement(name = "common-table-expression")
- private List<ExpectedCommonTableExpressionClause> commonTableExpressions = new LinkedList<>();
+ private final List<ExpectedCommonTableExpressionClause> commonTableExpressions = new LinkedList<>();
}
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/statement/ddl/CreateIndexStatementTestCase.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/statement/ddl/CreateIndexStatementTestCase.java
index 50f7bb99ac5..234f5b89612 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/statement/ddl/CreateIndexStatementTestCase.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/statement/ddl/CreateIndexStatementTestCase.java
@@ -42,5 +42,5 @@ public final class CreateIndexStatementTestCase extends SQLParserTestCase {
private ExpectedTable table;
@XmlElement(name = "column")
- private List<ExpectedColumn> columns = new LinkedList<>();
+ private final List<ExpectedColumn> columns = new LinkedList<>();
}
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/statement/dml/CopyStatementTestCase.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/statement/dml/CopyStatementTestCase.java
index 3c1a0e4a0cc..f7583e2255d 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/statement/dml/CopyStatementTestCase.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/statement/dml/CopyStatementTestCase.java
@@ -39,7 +39,7 @@ public final class CopyStatementTestCase extends SQLParserTestCase {
private ExpectedSimpleTable table;
@XmlElement(name = "column")
- private List<ExpectedColumn> columns = new LinkedList<>();
+ private final List<ExpectedColumn> columns = new LinkedList<>();
@XmlElement
private ExpectedPrepareStatementQuery query;
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/statement/ral/migration/ShowMigrationStatusStatementTestCase.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/statement/ral/migration/ShowMigrationStatusStatementTestCase.java
index fca678cfab3..e66872375f7 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/statement/ral/migration/ShowMigrationStatusStatementTestCase.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/cases/parser/domain/statement/ral/migration/ShowMigrationStatusStatementTestCase.java
@@ -23,6 +23,7 @@ import org.apache.shardingsphere.test.sql.parser.internal.cases.parser.domain.se
import org.apache.shardingsphere.test.sql.parser.internal.cases.parser.domain.statement.SQLParserTestCase;
import javax.xml.bind.annotation.XmlElement;
+import java.util.LinkedList;
import java.util.List;
/**
@@ -36,5 +37,5 @@ public final class ShowMigrationStatusStatementTestCase extends SQLParserTestCas
private String jobId;
@XmlElement(name = "type-strategy")
- private List<ExpectedAlgorithm> tableStrategies;
+ private final List<ExpectedAlgorithm> tableStrategies = new LinkedList<>();
}