You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Siddharth Seth (JIRA)" <ji...@apache.org> on 2014/08/28 23:53:11 UTC

[jira] [Commented] (TEZ-1488) Implement HashComparator in TezBytesComparator

    [ https://issues.apache.org/jira/browse/TEZ-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114428#comment-14114428 ] 

Siddharth Seth commented on TEZ-1488:
-------------------------------------

+1. Looks good.
Some documentation on the HashComparator interface will be useful on what it is used for. Also is getHashCode the correct name - something like extractKeyMSBytes may be more appropriate.

> Implement HashComparator<BytesWritable> in TezBytesComparator
> -------------------------------------------------------------
>
>                 Key: TEZ-1488
>                 URL: https://issues.apache.org/jira/browse/TEZ-1488
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.6.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>         Attachments: TEZ-1488.1.patch
>
>
> Speed up TezBytesComparator by ~20% when used in PipelinedSorter.
> This moves part of the key comparator into the partition comparator, which is a single register operation.



--
This message was sent by Atlassian JIRA
(v6.2#6252)