You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/05/22 18:35:25 UTC
[Impala-ASF-CR] Fix test failure introduced by IMPALA-8834
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15979
Change subject: Fix test failure introduced by IMPALA-8834
......................................................................
Fix test failure introduced by IMPALA-8834
Testing:
impala-py.test tests/query_test/test_queries.py \
--workload_exploration_strategy=functional-query:exhaustive \
-k HdfsQueries
Change-Id: Icff4ad909223241b2d6844aa6cc5096aa3487ecb
---
M tests/query_test/test_queries.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/15979/1
--
To view, visit http://gerrit.cloudera.org:8080/15979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icff4ad909223241b2d6844aa6cc5096aa3487ecb
Gerrit-Change-Number: 15979
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9776: Fix test failure introduced by IMPALA-8834
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15979
to look at the new patch set (#2).
Change subject: IMPALA-9776: Fix test failure introduced by IMPALA-8834
......................................................................
IMPALA-9776: Fix test failure introduced by IMPALA-8834
Testing:
impala-py.test tests/query_test/test_queries.py \
--workload_exploration_strategy=functional-query:exhaustive \
-k HdfsQueries
Change-Id: Icff4ad909223241b2d6844aa6cc5096aa3487ecb
---
M tests/query_test/test_queries.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/15979/2
--
To view, visit http://gerrit.cloudera.org:8080/15979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icff4ad909223241b2d6844aa6cc5096aa3487ecb
Gerrit-Change-Number: 15979
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9776: Fix test failure introduced by IMPALA-8834
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/15979 )
Change subject: IMPALA-9776: Fix test failure introduced by IMPALA-8834
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icff4ad909223241b2d6844aa6cc5096aa3487ecb
Gerrit-Change-Number: 15979
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 May 2020 18:46:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9776: Fix test failure introduced by IMPALA-8834
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15979 )
Change subject: IMPALA-9776: Fix test failure introduced by IMPALA-8834
......................................................................
IMPALA-9776: Fix test failure introduced by IMPALA-8834
Testing:
impala-py.test tests/query_test/test_queries.py \
--workload_exploration_strategy=functional-query:exhaustive \
-k HdfsQueries
Change-Id: Icff4ad909223241b2d6844aa6cc5096aa3487ecb
Reviewed-on: http://gerrit.cloudera.org:8080/15979
Tested-by: Tim Armstrong <ta...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Sahil Takiar <st...@cloudera.com>
---
M tests/query_test/test_queries.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tim Armstrong: Verified
Wenzhe Zhou: Looks good to me, but someone else must approve
Sahil Takiar: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icff4ad909223241b2d6844aa6cc5096aa3487ecb
Gerrit-Change-Number: 15979
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-9776: Fix test failure introduced by IMPALA-8834
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15979 )
Change subject: IMPALA-9776: Fix test failure introduced by IMPALA-8834
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icff4ad909223241b2d6844aa6cc5096aa3487ecb
Gerrit-Change-Number: 15979
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 May 2020 19:05:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9776: Fix test failure introduced by IMPALA-8834
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15979 )
Change subject: IMPALA-9776: Fix test failure introduced by IMPALA-8834
......................................................................
Patch Set 2: Verified+1
I'm going to manually verify this since it's so trivial and I could test locally.
--
To view, visit http://gerrit.cloudera.org:8080/15979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icff4ad909223241b2d6844aa6cc5096aa3487ecb
Gerrit-Change-Number: 15979
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 May 2020 18:39:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9776: Fix test failure introduced by IMPALA-8834
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15979 )
Change subject: IMPALA-9776: Fix test failure introduced by IMPALA-8834
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6128/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icff4ad909223241b2d6844aa6cc5096aa3487ecb
Gerrit-Change-Number: 15979
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 May 2020 19:28:40 +0000
Gerrit-HasComments: No