You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/22 09:21:20 UTC

[GitHub] [arrow] guyuqi opened a new pull request #12687: ARROW-15995: [GO] Improve 'sum_float64_neon' performance

guyuqi opened a new pull request #12687:
URL: https://github.com/apache/arrow/pull/12687


   Improve the 'Float64Funcs_Sum_1000000-64':
   
   From:
   BenchmarkFloat64Funcs_Sum_1000000-64                1179           1016745 ns/op        7868.25 MB/s
   to:
   BenchmarkFloat64Funcs_Sum_1000000-64                1387            849128 ns/op        9421.43 MB/s
   
   Get 19.7% performance uplift in cases which data set is larger than 1MB.
   
   
   Test:
   ```
   ARM_ENABLE_EXT=NEON go test
   PASS
   ok      github.com/apache/arrow/go/v8/arrow/math        0.010s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #12687: ARROW-15995: [GO] Improve 'sum_float64_neon' performance

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12687:
URL: https://github.com/apache/arrow/pull/12687#issuecomment-1079742864


   Benchmark runs are scheduled for baseline = 5bd4d8ec279d1e9263b99a6bac619d80fe7dee42 and contender = 08bfd4c68d0ef73d87a2381a7dacde50a7443087. 08bfd4c68d0ef73d87a2381a7dacde50a7443087 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e41751e728ce4dfcbb5358c6ea401bb2...49b8ae9e4257412b94d75fb72a4a13ba/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e6f545f5e8414a6c8c9e67170d195418...8a52d65c9e334a1ba727f9bd8889c4d8/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f053678d25a64e86b8104dab34d1a79b...4c1b6fa14d314235bd398e4823fb186a/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f5e70fd8cff84a5e885fa7c9bc1dccbe...11fe7de1b29f470ea71f5660aae62145/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12687: ARROW-15995: [GO] Improve 'sum_float64_neon' performance

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12687:
URL: https://github.com/apache/arrow/pull/12687#issuecomment-1079742864


   Benchmark runs are scheduled for baseline = 5bd4d8ec279d1e9263b99a6bac619d80fe7dee42 and contender = 08bfd4c68d0ef73d87a2381a7dacde50a7443087. 08bfd4c68d0ef73d87a2381a7dacde50a7443087 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e41751e728ce4dfcbb5358c6ea401bb2...49b8ae9e4257412b94d75fb72a4a13ba/)
   [Finished :arrow_down:0.67% :arrow_up:0.13%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e6f545f5e8414a6c8c9e67170d195418...8a52d65c9e334a1ba727f9bd8889c4d8/)
   [Failed :arrow_down:0.71% :arrow_up:0.36%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f053678d25a64e86b8104dab34d1a79b...4c1b6fa14d314235bd398e4823fb186a/)
   [Finished :arrow_down:0.21% :arrow_up:0.13%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f5e70fd8cff84a5e885fa7c9bc1dccbe...11fe7de1b29f470ea71f5660aae62145/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zeroshade closed pull request #12687: ARROW-15995: [GO] Improve 'sum_float64_neon' performance

Posted by GitBox <gi...@apache.org>.
zeroshade closed pull request #12687:
URL: https://github.com/apache/arrow/pull/12687


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #12687: ARROW-15995: [GO] Improve 'sum_float64_neon' performance

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12687:
URL: https://github.com/apache/arrow/pull/12687#issuecomment-1074922584


   https://issues.apache.org/jira/browse/ARROW-15995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12687: ARROW-15995: [GO] Improve 'sum_float64_neon' performance

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12687:
URL: https://github.com/apache/arrow/pull/12687#issuecomment-1079742864


   Benchmark runs are scheduled for baseline = 5bd4d8ec279d1e9263b99a6bac619d80fe7dee42 and contender = 08bfd4c68d0ef73d87a2381a7dacde50a7443087. 08bfd4c68d0ef73d87a2381a7dacde50a7443087 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:25.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e41751e728ce4dfcbb5358c6ea401bb2...49b8ae9e4257412b94d75fb72a4a13ba/)
   [Finished :arrow_down:0.67% :arrow_up:0.13%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e6f545f5e8414a6c8c9e67170d195418...8a52d65c9e334a1ba727f9bd8889c4d8/)
   [Failed :arrow_down:0.71% :arrow_up:0.36%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f053678d25a64e86b8104dab34d1a79b...4c1b6fa14d314235bd398e4823fb186a/)
   [Finished :arrow_down:0.21% :arrow_up:0.13%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f5e70fd8cff84a5e885fa7c9bc1dccbe...11fe7de1b29f470ea71f5660aae62145/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12687: ARROW-15995: [GO] Improve 'sum_float64_neon' performance

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12687:
URL: https://github.com/apache/arrow/pull/12687#issuecomment-1079742864


   Benchmark runs are scheduled for baseline = 5bd4d8ec279d1e9263b99a6bac619d80fe7dee42 and contender = 08bfd4c68d0ef73d87a2381a7dacde50a7443087. 08bfd4c68d0ef73d87a2381a7dacde50a7443087 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e41751e728ce4dfcbb5358c6ea401bb2...49b8ae9e4257412b94d75fb72a4a13ba/)
   [Finished :arrow_down:0.67% :arrow_up:0.13%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e6f545f5e8414a6c8c9e67170d195418...8a52d65c9e334a1ba727f9bd8889c4d8/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f053678d25a64e86b8104dab34d1a79b...4c1b6fa14d314235bd398e4823fb186a/)
   [Finished :arrow_down:0.21% :arrow_up:0.13%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f5e70fd8cff84a5e885fa7c9bc1dccbe...11fe7de1b29f470ea71f5660aae62145/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12687: ARROW-15995: [GO] Improve 'sum_float64_neon' performance

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12687:
URL: https://github.com/apache/arrow/pull/12687#issuecomment-1079742864


   Benchmark runs are scheduled for baseline = 5bd4d8ec279d1e9263b99a6bac619d80fe7dee42 and contender = 08bfd4c68d0ef73d87a2381a7dacde50a7443087. 08bfd4c68d0ef73d87a2381a7dacde50a7443087 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e41751e728ce4dfcbb5358c6ea401bb2...49b8ae9e4257412b94d75fb72a4a13ba/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e6f545f5e8414a6c8c9e67170d195418...8a52d65c9e334a1ba727f9bd8889c4d8/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f053678d25a64e86b8104dab34d1a79b...4c1b6fa14d314235bd398e4823fb186a/)
   [Finished :arrow_down:0.21% :arrow_up:0.13%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f5e70fd8cff84a5e885fa7c9bc1dccbe...11fe7de1b29f470ea71f5660aae62145/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org