[GitHub] [lucene-solr] gerlowskija commented on issue #665: Fixes SOLR-13539

[GitBox <gi...@apache.org>]

gerlowskija commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-537556502
 
 
   Hi Thomas.  I'd really like to get this (#665) in for 8.3, but right now it's bundled to your change in #883.  I can't merge this without #883.
   
   And I haven't had the time I need to understand how the different pieces of #883 (response formats, field types, binary content) fit together and what the best design is there.
   
   So what I'm going to do is try to unbundle the two PRs, or at least flip the ordering.  I'll take what you've uploaded to #665 here and either comment out or remove entirely the tests that hit this binary-XML issue.  They can be added back in #883, once binary-xml works for these field types.
     
   There might still be time to get #883 in, as I have a chunk of time now that I didn't before.  But even if we don't get to it for 8.3, it won't prevent #665 from getting in.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org