You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "yikf (via GitHub)" <gi...@apache.org> on 2026/08/04 06:05:37 UTC

[PR] [MINOR][VL] Re-enable the ignored weekday test in VeloxStringFunctionsSuite [gluten]

yikf opened a new pull request, #12688:
URL: https://github.com/apache/gluten/pull/12688

   <!--
   Thank you for submitting a pull request! Here are some tips:
   
   1. For first-time contributors, please read our contributing guide:
      https://github.com/apache/gluten/blob/main/CONTRIBUTING.md
   2. If necessary, create a GitHub issue for discussion beforehand to avoid duplicate work.
   3. If the PR is specific to a single backend, include [VL] or [CH] in the PR title to indicate the
      Velox or ClickHouse backend, respectively.
   4. If the PR is not ready for review, please mark it as a draft.
   -->
   
   ## What changes are proposed in this pull request?
   
   <!--
   Provide a clear and concise description of the changes introduced in this PR.
   Ensure the PR description aligns with the code changes, especially after updates.
   If applicable, include "Fixes #<GitHub_Issue_ID>" to automatically close the corresponding issue
   when the PR is merged.
   -->
   The `weekday` Spark function was fully enabled in #4721 (WEEK_DAY -> Velox `weekday`), whose semantics (Monday=0 ... Sunday=6) already match Spark's WeekDay. 
   
   However, the corresponding test was left as `ignore` with a stale "result mismatched" note that no longer applies. Re-enable it as a regular test, consistent with the adjacent `dayofweek` test.
   
   ## How was this patch tested?
   
   <!--
   Describe how the changes were tested, if applicable.
   Include new tests to validate the functionality, if necessary.
   For UI-related changes, attach screenshots to demonstrate the updates.
   -->
   
   Re-enable the ignored weekday test.
   ## Was this patch authored or co-authored using generative AI tooling?
   
   <!--
   If generative AI tooling has been used in the process of authoring this patch, please include the
   phrase: 'Generated-by: ' followed by the name of the tool and its version.
   If no, write 'No'.
   Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
   -->
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [MINOR][VL] Re-enable the ignored weekday test in VeloxStringFunctionsSuite [gluten]

Posted by "philo-he (via GitHub)" <gi...@apache.org>.
philo-he merged PR #12688:
URL: https://github.com/apache/gluten/pull/12688


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [MINOR][VL] Re-enable the ignored weekday test in VeloxStringFunctionsSuite [gluten]

Posted by "yikf (via GitHub)" <gi...@apache.org>.
yikf commented on PR #12688:
URL: https://github.com/apache/gluten/pull/12688#issuecomment-5175245074

   @philo-he Could you please take a look, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org