You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Vetrivel Chinnasamy <ve...@citrix.com> on 2014/03/05 10:01:51 UTC

Re: Review Request 18194: G11N: Fixed the Hardcoding Issue

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18194/
-----------------------------------------------------------

(Updated March 5, 2014, 9:01 a.m.)


Review request for cloudstack and Brian Federle.


Repository: cloudstack-git


Description
-------

Externalized the hard coded strings by adding reference ID and label to the resource files. Also updated the dictionary.jsp file.


Diffs (updated)
-----

  client/WEB-INF/classes/resources/messages.properties 82ac499 
  client/WEB-INF/classes/resources/messages_ja_JP.properties 828cf54 
  client/WEB-INF/classes/resources/messages_zh_CN.properties f4c206b 
  tools/ngui/static/js/app/accounts/accounts.js eae5070 
  tools/ngui/static/js/app/storage/storage.js e562a95 
  ui/dictionary.jsp 11dbeb5 
  ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js d618b23 
  ui/scripts/configuration.js 869b876 
  ui/scripts/installWizard.js 25de4aa 
  ui/scripts/instances.js 53c9e98 
  ui/scripts/network.js 6ce66e8 
  ui/scripts/sharedFunctions.js f0afea5 
  ui/scripts/storage.js 1cd8d2e 
  ui/scripts/system.js c21e277 
  ui/scripts/templates.js 3551613 
  ui/scripts/ui-custom/zoneChart.js e847a19 
  ui/scripts/ui/core.js 06be12b 
  ui/scripts/ui/widgets/tagger.js 673bd43 
  ui/scripts/vpc.js 770ee9b 
  ui/scripts/zoneWizard.js 1de3646 

Diff: https://reviews.apache.org/r/18194/diff/


Testing
-------

Local unit testing done by replacing the java-script, dictionary.jsp and properties files.


Thanks,

Vetrivel Chinnasamy

Re: Review Request 18194: G11N: Fixed the Hardcoding Issue

Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18194/#review36277
-----------------------------------------------------------

Ship it!


Ship It!

- Brian Federle


On March 5, 2014, 9:01 a.m., Vetrivel Chinnasamy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18194/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 9:01 a.m.)
> 
> 
> Review request for cloudstack and Brian Federle.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Externalized the hard coded strings by adding reference ID and label to the resource files. Also updated the dictionary.jsp file.
> 
> 
> Diffs
> -----
> 
>   client/WEB-INF/classes/resources/messages.properties 82ac499 
>   client/WEB-INF/classes/resources/messages_ja_JP.properties 828cf54 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties f4c206b 
>   tools/ngui/static/js/app/accounts/accounts.js eae5070 
>   tools/ngui/static/js/app/storage/storage.js e562a95 
>   ui/dictionary.jsp 11dbeb5 
>   ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js d618b23 
>   ui/scripts/configuration.js 869b876 
>   ui/scripts/installWizard.js 25de4aa 
>   ui/scripts/instances.js 53c9e98 
>   ui/scripts/network.js 6ce66e8 
>   ui/scripts/sharedFunctions.js f0afea5 
>   ui/scripts/storage.js 1cd8d2e 
>   ui/scripts/system.js c21e277 
>   ui/scripts/templates.js 3551613 
>   ui/scripts/ui-custom/zoneChart.js e847a19 
>   ui/scripts/ui/core.js 06be12b 
>   ui/scripts/ui/widgets/tagger.js 673bd43 
>   ui/scripts/vpc.js 770ee9b 
>   ui/scripts/zoneWizard.js 1de3646 
> 
> Diff: https://reviews.apache.org/r/18194/diff/
> 
> 
> Testing
> -------
> 
> Local unit testing done by replacing the java-script, dictionary.jsp and properties files.
> 
> 
> Thanks,
> 
> Vetrivel Chinnasamy
> 
>