You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/12/12 09:56:15 UTC
[GitHub] [netbeans] JaroslavTulach commented on issue #1771: [NETBEANS-3428]
FlatLaf: UI delegates for editor and view tabs in main window
JaroslavTulach commented on issue #1771: [NETBEANS-3428] FlatLaf: UI delegates for editor and view tabs in main window
URL: https://github.com/apache/netbeans/pull/1771#issuecomment-564934273
> Seems that sigtest has problems with public or protected methods that return (package) private types.
It is not sigtest that has a problem. The library exposing such methods has a problem!
Why should an API expose a method that returns package private type? What the callers are going to do with it? How will the Javadoc look like? Having such methods just doesn't make any sense when designing Java APIs.
Of course, the problem is when a 3rd party library which hasn't really paid much attention to its API is then re-exported by NetBeans module and becomes subject to signature testing. There are three possible solutions I can think of:
- disable the signature testing
- fix the library
- improve [sigtest](https://github.com/jtulach/netbeans-apitest) to have an option that would allow the above practice
As an author of [Practical API Design](http://apidesign.org) I am in favor of fixing the library, but I understand that it may be more practical to choose one of the other solutions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists