[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8463: ARROW-10163: [Rust] [DataFusion] Add DictionaryArray coercion support

[GitBox <gi...@apache.org>]

jorgecarleitao commented on a change in pull request #8463:
URL: https://github.com/apache/arrow/pull/8463#discussion_r506793405



##########
File path: rust/datafusion/tests/sql.rs
##########
@@ -930,14 +930,20 @@ fn register_alltypes_parquet(ctx: &mut ExecutionContext) {
 /// Execute query and return result set as 2-d table of Vecs
 /// `result[row][column]`
 async fn execute(ctx: &mut ExecutionContext, sql: &str) -> Vec<Vec<String>> {
-    let plan = ctx.create_logical_plan(&sql).unwrap();
+    let msg = format!("Creating logical plan for '{}'", sql);
+    let plan = ctx.create_logical_plan(&sql).expect(&msg);

Review comment:
       an alternative here is return `Result` and place a `?`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org