You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/22 19:02:18 UTC
[GitHub] [arrow-datafusion] thinkharderdev opened a new pull request #2060: Change log level for noisy logs
thinkharderdev opened a new pull request #2060:
URL: https://github.com/apache/arrow-datafusion/pull/2060
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
These two logs statements were creating a lot of noise. They can be valuable for debugging but think they should be debug logs instead of info logs.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Ted-Jiang commented on pull request #2060: Change log level for noisy logs
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on pull request #2060:
URL: https://github.com/apache/arrow-datafusion/pull/2060#issuecomment-1079594124
> Hi, @Ted-Jiang @yahoNanJing
>
> I think in the pull based task assignment model, if the system is idle, maybe we should let the executor slow down the polling interval. Otherwise there will be too many RPCs between Scheduler and Executor if there are many Executor nodes in the system even when the system is idle.
Thanks @mingmwang its a good idea. Now we hard code it in 1 mins:
https://github.com/apache/arrow-datafusion/blob/8de2a7610df33adf75ba515c4ee2fe935f7aa114/ballista/rust/executor/src/executor_server.rs#L263
How to test the best interval is a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Ted-Jiang edited a comment on pull request #2060: Change log level for noisy logs
Posted by GitBox <gi...@apache.org>.
Ted-Jiang edited a comment on pull request #2060:
URL: https://github.com/apache/arrow-datafusion/pull/2060#issuecomment-1079594124
> Hi, @Ted-Jiang @yahoNanJing
>
> I think in the pull based task assignment model, if the system is idle, maybe we should let the executor slow down the polling interval. Otherwise there will be too many RPCs between Scheduler and Executor if there are many Executor nodes in the system even when the system is idle.
Thanks @mingmwang its a good idea. Now we hard code it in 1 mins:
https://github.com/apache/arrow-datafusion/blob/8de2a7610df33adf75ba515c4ee2fe935f7aa114/ballista/rust/executor/src/executor_server.rs#L263
How to test the best interval is a problem. @mingmwang ans suggestions 😊?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mingmwang commented on pull request #2060: Change log level for noisy logs
Posted by GitBox <gi...@apache.org>.
mingmwang commented on pull request #2060:
URL: https://github.com/apache/arrow-datafusion/pull/2060#issuecomment-1078778551
Hi, @Ted-Jiang @yahoNanJing
I think in the pull based task assignment model, if the system is idle, maybe we should let the executor slow down the polling interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen merged pull request #2060: Change log level for noisy logs
Posted by GitBox <gi...@apache.org>.
yjshen merged pull request #2060:
URL: https://github.com/apache/arrow-datafusion/pull/2060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mingmwang edited a comment on pull request #2060: Change log level for noisy logs
Posted by GitBox <gi...@apache.org>.
mingmwang edited a comment on pull request #2060:
URL: https://github.com/apache/arrow-datafusion/pull/2060#issuecomment-1078778551
Hi, @Ted-Jiang @yahoNanJing
I think in the pull based task assignment model, if the system is idle, maybe we should let the executor slow down the polling interval. Otherwise there will be too many RPCs between Scheduler and Executor if there are many Executor nodes in the system even when the system is idle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org