[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #174: HDDS-2493. Sonar: Locking on a parameter in NetUtils.removeOutscope.

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #174: HDDS-2493. Sonar: Locking on a parameter in NetUtils.removeOutscope.
URL: https://github.com/apache/hadoop-ozone/pull/174#discussion_r346915406
 
 

 ##########
 File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NetUtils.java
 ##########
 @@ -32,6 +32,8 @@
  */
 public final class NetUtils {
   public static final Logger LOG = LoggerFactory.getLogger(NetUtils.class);
+  private static final Object EXCLUDE_NODES_LOCK = new Object();
 
 Review comment:
   I think moving `removeOutOfScope` to `NetworkTopologyImpl` and making it non-static would be more future-proof.  Syncing on a static object seems risky.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org