[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #9447: [fix] UT MathFunctionTest.round_test fix

[GitBox <gi...@apache.org>]

BiteTheDDDDt commented on code in PR #9447:
URL: https://github.com/apache/incubator-doris/pull/9447#discussion_r867343908


##########
be/src/vec/functions/function_binary_arithmetic.h:
##########
@@ -756,6 +756,16 @@ class FunctionBinaryArithmetic : public IFunction {
 
     size_t get_number_of_arguments() const override { return 2; }
 
+    DataTypes get_variadic_argument_types_impl() const override {
+        using OpImpl = Operation<typename OpTraits::T, typename OpTraits::T>;
+        constexpr bool has_variadic_argument =

Review Comment:
   Maybe we can move `has_variadic_argument` to OperationTraits?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org