You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gora.apache.org by Patricio Echagüe <pa...@gmail.com> on 2012/01/15 21:00:03 UTC

Comments about Hector usage

- CassandraClient#checkKeyspace() :

    Not sure if this is intentional but ideally during a keyspace creation
you may want to block until the whole cluster converge to the new keyspace.
You can achieve that by adding an extra boolean parameter during the method
call: -> this.cluster.addKeyspace(keyspaceDefinition, true);
    Hector will block until all nodes in the cluster agree on the new
keyspace.

- Is there a way in Gora to define the Consistency used for read and write
operations? I see the CassandraClient (Hector) being used with default
values.

- CassandraStore#addOrUpdateField contains a switch statement to evaluate
different types of column values but in the end the cassandraClient object
end up converting to string anyway. I think, the InferringTypeSerializer
can be used instead in order to take advantage of when the value is already
of type ByteBuffer.


I know you guys are just starting to work on this. These are minor comments
and it looks like Hector is being used in the right way.

No more comments so far.

Cheers
Patricio

Re: Comments about Hector usage

Posted by Patricio Echagüe <pa...@gmail.com>.

thanks Lewis. I'll definitely try to submit a patch.

Sent from my Android
On Jan 16, 2012 3:04 AM, "Lewis John Mcgibbney" <le...@gmail.com>
wrote:

> Hi Patricio,
>
> This is great feedback thanks very much. To log and deal with the points
> you raise I've opened some tickets on our Jira issue tracker. The parent
> issue is here [1]. At this stage, when I get a bit of time I'll try my best
> to have a look and get some patches submitted, however if you are available
> or get a bit of spare time and wish to submit any work then please feel
> free to add your implementations, anything would be greatly appreciated.
>
> Thanks again for reporting this.
>
> Best
>
> Lewis
>
> [1] https://issues.apache.org/jira/browse/GORA-78
>
> 2012/1/15 Patricio Echagüe <pa...@gmail.com>
>
> > - CassandraClient#checkKeyspace() :
> >
> >    Not sure if this is intentional but ideally during a keyspace creation
> > you may want to block until the whole cluster converge to the new
> keyspace.
> > You can achieve that by adding an extra boolean parameter during the
> method
> > call: -> this.cluster.addKeyspace(keyspaceDefinition, true);
> >    Hector will block until all nodes in the cluster agree on the new
> > keyspace.
> >
> > - Is there a way in Gora to define the Consistency used for read and
> write
> > operations? I see the CassandraClient (Hector) being used with default
> > values.
> >
> > - CassandraStore#addOrUpdateField contains a switch statement to evaluate
> > different types of column values but in the end the cassandraClient
> object
> > end up converting to string anyway. I think, the InferringTypeSerializer
> > can be used instead in order to take advantage of when the value is
> already
> > of type ByteBuffer.
> >
> >
> > I know you guys are just starting to work on this. These are minor
> comments
> > and it looks like Hector is being used in the right way.
> >
> > No more comments so far.
> >
> > Cheers
> > Patricio
> >
>
>
>
> --
> *Lewis*
>

Re: Comments about Hector usage

Posted by Lewis John Mcgibbney <le...@gmail.com>.

Hi Patricio,

This is great feedback thanks very much. To log and deal with the points
you raise I've opened some tickets on our Jira issue tracker. The parent
issue is here [1]. At this stage, when I get a bit of time I'll try my best
to have a look and get some patches submitted, however if you are available
or get a bit of spare time and wish to submit any work then please feel
free to add your implementations, anything would be greatly appreciated.

Thanks again for reporting this.

Best

Lewis

[1] https://issues.apache.org/jira/browse/GORA-78

2012/1/15 Patricio Echagüe <pa...@gmail.com>

> - CassandraClient#checkKeyspace() :
>
>    Not sure if this is intentional but ideally during a keyspace creation
> you may want to block until the whole cluster converge to the new keyspace.
> You can achieve that by adding an extra boolean parameter during the method
> call: -> this.cluster.addKeyspace(keyspaceDefinition, true);
>    Hector will block until all nodes in the cluster agree on the new
> keyspace.
>
> - Is there a way in Gora to define the Consistency used for read and write
> operations? I see the CassandraClient (Hector) being used with default
> values.
>
> - CassandraStore#addOrUpdateField contains a switch statement to evaluate
> different types of column values but in the end the cassandraClient object
> end up converting to string anyway. I think, the InferringTypeSerializer
> can be used instead in order to take advantage of when the value is already
> of type ByteBuffer.
>
>
> I know you guys are just starting to work on this. These are minor comments
> and it looks like Hector is being used in the right way.
>
> No more comments so far.
>
> Cheers
> Patricio
>



-- 
*Lewis*