[GitHub] [arrow-datafusion] alamb commented on a change in pull request #706: Rename concurrency to target_partitions

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #706:
URL: https://github.com/apache/arrow-datafusion/pull/706#discussion_r693484416



##########
File path: datafusion/src/logical_plan/builder.rs
##########
@@ -147,10 +147,10 @@ impl LogicalPlanBuilder {
     pub fn scan_parquet_with_name(
         path: impl Into<String>,
         projection: Option<Vec<usize>>,
-        max_concurrency: usize,
+        max_partitions: usize,
         table_name: impl Into<String>,
     ) -> Result<Self> {
-        let provider = Arc::new(ParquetTable::try_new(path, max_concurrency)?);
+        let provider = Arc::new(ParquetTable::try_new(path, max_partitions)?);

Review comment:
       Filed https://github.com/apache/arrow-datafusion/issues/924 to track

##########
File path: datafusion/src/execution/context.rs
##########
@@ -665,13 +665,13 @@ pub struct ExecutionConfig {
     /// virtual tables for displaying schema information
     information_schema: bool,
     /// Should DataFusion repartition data using the join keys to execute joins in parallel
-    /// using the provided `concurrency` level
+    /// using the provided `default_partitions` level

Review comment:
       I think some of these references to `default_partitions` should probably be updated to `target_partitions` to match the new field name. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org