[jira] [Commented] (NIFI-3718) TestAvroRecordReader fails due to timezone issue

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975437#comment-15975437 ] 

ASF GitHub Bot commented on NIFI-3718:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/1683

    NIFI-3718: Fixed TestAvroRecordReader to handle timezone differences

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-3718

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1683.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1683
    
----
commit 18fc35f2d962e0b7efb663bf6c390f9c7a7093b2
Author: Matt Burgess <ma...@apache.org>
Date:   2017-04-19T20:17:35Z

    NIFI-3718: Fixed TestAvroRecordReader to handle timezone differences

----


> TestAvroRecordReader fails due to timezone issue
> ------------------------------------------------
>
>                 Key: NIFI-3718
>                 URL: https://issues.apache.org/jira/browse/NIFI-3718
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Tools and Build
>    Affects Versions: 1.2.0
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>             Fix For: 1.2.0
>
>
> TestAvroRecord is failing on Travis due to a timezone issue, it seems to fail when using GMT/UTC (which Travis apparently uses) but passes in other timezones such as EDT.
> It looks like the issue is with the test using Date.toString() in the assert statement, the internal value is correct but when converted to a String, the value in the "date" field in the record should be a day later (April 5) but is not.
> Proposed fix is to decrement the value in the "date" field in the test record, and use a GMT-based DateFormat to format the value of the "date" field.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)