[jira] Updated: (DERBY-1783) Logical error in code for determining mode for opening of log files

["Olav Sandstaa (JIRA)" <de...@db.apache.org>]

     [ http://issues.apache.org/jira/browse/DERBY-1783?page=all ]

Olav Sandstaa updated DERBY-1783:
---------------------------------

    Attachment: rwsync.diff

Patch that fixes the logical code error by adding parentheses around the OR clause. In addition one minor fix to the javadoc for the method is done. 

The patch touches the following file:

M      java/engine/org/apache/derby/impl/io/DirFile4.java

I have run derbyall on Solaris 10 x86 with JVM 1.5 with no failures. The patch is ready for review and commit.

> Logical error in code for determining mode for opening of log files
> -------------------------------------------------------------------
>
>                 Key: DERBY-1783
>                 URL: http://issues.apache.org/jira/browse/DERBY-1783
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.2.1.0
>         Environment: JVM 1.4.2 and later
>            Reporter: Olav Sandstaa
>         Assigned To: Olav Sandstaa
>            Priority: Trivial
>             Fix For: 10.3.0.0
>
>         Attachments: rwsync.diff
>
>
> There is a logical error in the following function in DirFile4.java
> for determining which mode to use when opening a new log file:
>     public StorageRandomAccessFile getRandomAccessFile( String mode) throws FileNotFoundException
>     {
>         // Assume that modes "rws" and "rwd" are not supported.
>         if(!rwsOK && "rws".equals( mode) || "rwd".equals( mode))
>             mode = "rw";
>         return new DirRandomAccessFile4( (File) this, mode);
>     } // end of getRandomAccessFile
> The expression in the if test is missing parentheses around the OR
> expression making it return the wrong value for one case. If "rwd"
> mode is requested for the file (and this is supported by the JVM), the
> file is opened with "rw" instead of "rwd".
> NOTE: this bug does not effect any current Derby versions since as far
> as I know "rwd" is never used for log files. I came across it when
> experimenting with using "rwd" for the log.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira