[jira] [Commented] (AIRFLOW-869) Web UI Mark Success Upstream Option Bug

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707135#comment-16707135 ] 

ASF GitHub Bot commented on AIRFLOW-869:
----------------------------------------

kaxil closed pull request #2074: [AIRFLOW-869] Web UI Mark Success Upstream Option Bug
URL: https://github.com/apache/incubator-airflow/pull/2074
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/airflow/www/views.py b/airflow/www/views.py
index d7c46a746b..fc49d7adaf 100644
--- a/airflow/www/views.py
+++ b/airflow/www/views.py
@@ -1123,7 +1123,7 @@ def success(self):
             if recursive:
                 recurse_tasks(relatives, task_ids, dag_ids, task_id_to_dag)
         if upstream:
-            relatives = task.get_flat_relatives(upstream=False)
+            relatives = task.get_flat_relatives(upstream=True)
             task_ids += [t.task_id for t in relatives]
             if recursive:
                 recurse_tasks(relatives, task_ids, dag_ids, task_id_to_dag)


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Web UI Mark Success Upstream Option Bug
> ---------------------------------------
>
>                 Key: AIRFLOW-869
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-869
>             Project: Apache Airflow
>          Issue Type: Bug
>    Affects Versions: 1.8.0
>            Reporter: Yi Chen
>            Priority: Major
>             Fix For: 1.8.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> A simple bug report: I tracked down to the source code of Airflow Web UI, look at this line, https://github.com/apache/incubator-airflow/blob/v1-8-stable/airflow/www/views.py#L1127 .  It should be `relatives = task.get_flat_relatives(upstream=True)`. But even with this fix, there are still issues about the "Mark Success" functionality. I hope we ship this bug fix along with v1.8. And I will open another ticket discussing the functionality of "Mark Success".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)