[GitHub] [cloudstack] utchoang commented on a change in pull request #4857: ui: Disable login button until redirected

[GitBox <gi...@apache.org>]

utchoang commented on a change in pull request #4857:
URL: https://github.com/apache/cloudstack/pull/4857#discussion_r600074511



##########
File path: ui/src/views/auth/Login.vue
##########
@@ -189,8 +189,8 @@ export default {
             }
             Login(loginParams)
               .then((res) => this.loginSuccess(res))
-              .catch(err => this.requestFailed(err))
-              .finally(() => {
+              .catch(err => {
+                this.requestFailed(err)
                 state.loginBtn = false

Review comment:
       @rhtyd I think it is correct because the goal is to only re-enable the button when it gets an error to perform click/submit again.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org