You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by caofangkun <gi...@git.apache.org> on 2015/03/24 05:03:56 UTC
[GitHub] storm pull request: STORM-553:add eclipse java formatter file for ...
GitHub user caofangkun opened a pull request:
https://github.com/apache/storm/pull/478
STORM-553:add eclipse java formatter file for Apache Storm Java Code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caofangkun/apache-storm storm-553
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/478.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #478
----
commit f95938b3d973a9d2513d0e326188f77b9bf438c8
Author: caofangkun <ca...@gmail.com>
Date: 2015-03-16T06:31:04Z
Merge pull request #12 from apache/master
Merge from apache/storm to caofangkun/apache-storm
commit 146bd6b7b18f03b338df78431654d7c54fa0e8a4
Author: caofangkun <ca...@gmail.com>
Date: 2015-03-18T01:17:37Z
Merge pull request #13 from apache/master
Merge from apache/storm to caofangkun/apache-storm
commit 57a691c865f764cf331abd2e2e6d27bd320813f8
Author: caofangkun <ca...@gmail.com>
Date: 2015-03-19T02:01:23Z
Merge pull request #14 from apache/master
Merge from apache/storm to caofangkun/apache-storm
commit 2c5b402381dbffd3942c0b67cdb8013462b5552a
Author: caofangkun <ca...@gmail.com>
Date: 2015-03-24T02:44:47Z
Merge pull request #15 from apache/master
Merge from apache/storm to caofangkun/apache-storm
commit 7302df4abd334c3f75bb86cb2a2470e61e9323f7
Author: caofangkun <ca...@gmail.com>
Date: 2015-03-24T04:00:38Z
STORM-553:add eclipse java formatter file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-553:add eclipse java formatter file for ...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/478#issuecomment-169013316
+1 for what @ptgoetz said.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #478: STORM-553:add eclipse java formatter file for Apache Storm...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/478
I'm going to close this. Please feel free to reopen or create a new PR once we have a style guide in place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #478: STORM-553:add eclipse java formatter file for Apach...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/478
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-553:add eclipse java formatter file for ...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/478#issuecomment-168884966
I'm all for adopting a code style guide for all languages (Java, Clojure, Python, etc.), but I'd rather see a style specification documented first, then follow up with templates that implement it.
I do feel that we have a lot of code style technical debt in both Java/Clojure. If we're moving away from clojure, we don't need to worry about style too much there, but we should establish a style guide for Java source, and start cleaning up compiler warnings, PMD/Checkstyle/Findbugs issues, etc.
I would suggest a discussion on the dev@ list, and hope it doesn't become too religious. ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-553:add eclipse java formatter file for ...
Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun commented on the pull request:
https://github.com/apache/storm/pull/478#issuecomment-91459270
@longdafeng
Different tools may define different tab size,the tab size may equivalent to 2 or 4 or 8 spaces/characters.
Defined tab size to 2 spaces, will be much easier to convert Tab(4) to 4 spaces and Tab(8) to 8 spaces.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-553:add eclipse java formatter file for ...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/478#issuecomment-169059247
@d2r Good point. I know there was some work done around moving to idiomatic clojure and making style consistent, but I don't think we ever put together a style guide. So our clojure code is relatively consistent in terms of style, but our java code is kind of all over the map.
I'd be in favor for establishing style guides for any languages we use.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-553:add eclipse java formatter file for ...
Posted by longdafeng <gi...@git.apache.org>.
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/478#issuecomment-90834098
why "indentation.size" and "tabulation.size" are 2, normally they are 4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-553:add eclipse java formatter file for ...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/478#issuecomment-169048850
+1 @ptgoetz , and I thought there was already a style for Clojure that we were supposed to use. I think even after moving mostly to Java, we will still have Clojure left. May as well include it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---