You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jason Fehr (Code Review)" <ge...@cloudera.org> on 2026/10/22 20:09:36 UTC

[Impala-ASF-CR] IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect

Jason Fehr has uploaded this change for review. ( http://gerrit.cloudera.org:8080/25186


Change subject: IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect
......................................................................

IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect

Modifies the Impala devcontainer container image build to set up a
git remote named "upstream" with a URL of "${GIT_REPO}" which uses
the GIT_REPO container build argument.

Testing accomplished by building new container image and running a
devcontainer using that image.

Change-Id: I7fa0c6c677583a8d1fc1450b4740c186cd06f3dd
---
M .devcontainer-build/Dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/25186/1
-- 
To view, visit http://gerrit.cloudera.org:8080/25186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fa0c6c677583a8d1fc1450b4740c186cd06f3dd
Gerrit-Change-Number: 25186
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>

[Impala-ASF-CR] IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/25186 )

Change subject: IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect
......................................................................

IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect

Modifies the Impala devcontainer container image build to set up a
git remote named "upstream" with a URL of "${GIT_REPO}" which uses
the GIT_REPO container build argument.

Testing accomplished by building new container image and running a
devcontainer using that image.

Change-Id: I7fa0c6c677583a8d1fc1450b4740c186cd06f3dd
---
M .devcontainer-build/Dockerfile
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/25186/2
-- 
To view, visit http://gerrit.cloudera.org:8080/25186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fa0c6c677583a8d1fc1450b4740c186cd06f3dd
Gerrit-Change-Number: 25186
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/25186 )

Change subject: IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/25186/1/.devcontainer-build/Dockerfile
File .devcontainer-build/Dockerfile:

http://gerrit.cloudera.org:8080/#/c/25186/1/.devcontainer-build/Dockerfile@169
PS1, Line 169: https://
What if the URL doesn't start with "https://"? E.g. "http://host.xz/path/to/repo.git/"


http://gerrit.cloudera.org:8080/#/c/25186/1/.devcontainer-build/build-devcontainer.sh
File .devcontainer-build/build-devcontainer.sh:

http://gerrit.cloudera.org:8080/#/c/25186/1/.devcontainer-build/build-devcontainer.sh@100
PS1, Line 100: GIT_REPO="$(git remote get-url "${GIT_REMOTE_NAME}" | cut -d'/' -f3- | cut -d'@' -f2-)"
This doesn't handle URLs like "git@github.com:apache/impala.git"



-- 
To view, visit http://gerrit.cloudera.org:8080/25186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fa0c6c677583a8d1fc1450b4740c186cd06f3dd
Gerrit-Change-Number: 25186
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Oct 2026 02:01:27 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25186 )

Change subject: IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14317/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/25186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fa0c6c677583a8d1fc1450b4740c186cd06f3dd
Gerrit-Change-Number: 25186
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sun, 25 Oct 2026 00:41:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/25186 )

Change subject: IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect
......................................................................

IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect

Modifies the Impala devcontainer container image build to set up a
git remote named "upstream" with a URL of "${GIT_REPO}" which uses
the GIT_REPO container build argument.

Testing accomplished by building new container image and running a
devcontainer using that image.

Change-Id: I7fa0c6c677583a8d1fc1450b4740c186cd06f3dd
Reviewed-on: http://gerrit.cloudera.org:8080/25186
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M .devcontainer-build/Dockerfile
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/25186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fa0c6c677583a8d1fc1450b4740c186cd06f3dd
Gerrit-Change-Number: 25186
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25186 )

Change subject: IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/25186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fa0c6c677583a8d1fc1450b4740c186cd06f3dd
Gerrit-Change-Number: 25186
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sun, 25 Oct 2026 00:41:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25186 )

Change subject: IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24660/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/25186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fa0c6c677583a8d1fc1450b4740c186cd06f3dd
Gerrit-Change-Number: 25186
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Oct 2026 16:23:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25186 )

Change subject: IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24651/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/25186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fa0c6c677583a8d1fc1450b4740c186cd06f3dd
Gerrit-Change-Number: 25186
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Oct 2026 20:31:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/25186 )

Change subject: IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/25186/1/.devcontainer-build/Dockerfile
File .devcontainer-build/Dockerfile:

http://gerrit.cloudera.org:8080/#/c/25186/1/.devcontainer-build/Dockerfile@169
PS1, Line 169: e); do g
> Adding an upstream git remote is intended to be a convenience.  No devconta
Ack


http://gerrit.cloudera.org:8080/#/c/25186/1/.devcontainer-build/build-devcontainer.sh
File .devcontainer-build/build-devcontainer.sh:

http://gerrit.cloudera.org:8080/#/c/25186/1/.devcontainer-build/build-devcontainer.sh@100
PS1, Line 100: GIT_REPO="$(git remote get-url "${GIT_REMOTE_NAME}" | cut -d'/' -f3- | cut -d'@' -f2-)"
> Given that this script will be run on container image build machines where 
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/25186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fa0c6c677583a8d1fc1450b4740c186cd06f3dd
Gerrit-Change-Number: 25186
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sun, 25 Oct 2026 00:41:01 +0000
Gerrit-HasComments: Yes