You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by jp...@apache.org on 2013/08/22 01:04:02 UTC
[2/2] git commit: TS-2116: create buffer_upload temp files with mode
0600
TS-2116: create buffer_upload temp files with mode 0600
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/36059e20
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/36059e20
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/36059e20
Branch: refs/heads/master
Commit: 36059e207307e90be17871ba5ddeb72ceecc4193
Parents: 87ccd26
Author: James Peach <jp...@apache.org>
Authored: Wed Aug 21 16:00:41 2013 -0700
Committer: James Peach <jp...@apache.org>
Committed: Wed Aug 21 16:01:13 2013 -0700
----------------------------------------------------------------------
plugins/experimental/buffer_upload/buffer_upload.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/36059e20/plugins/experimental/buffer_upload/buffer_upload.cc
----------------------------------------------------------------------
diff --git a/plugins/experimental/buffer_upload/buffer_upload.cc b/plugins/experimental/buffer_upload/buffer_upload.cc
index ae82135..fc496e4 100644
--- a/plugins/experimental/buffer_upload/buffer_upload.cc
+++ b/plugins/experimental/buffer_upload/buffer_upload.cc
@@ -916,7 +916,7 @@ attach_pvc_plugin(TSCont /* contp ATS_UNUSED */, TSEvent event, void *edata)
my_state->filename = tempnam(path, NULL);
TSDebug(DEBUG_TAG, "temp filename: %s", my_state->filename);
- my_state->fd = open(my_state->filename, O_RDWR | O_NONBLOCK | O_TRUNC | O_CREAT);
+ my_state->fd = open(my_state->filename, O_RDWR | O_NONBLOCK | O_TRUNC | O_CREAT, 0600);
if (my_state->fd < 0) {
LOG_ERROR("open");
uconfig->use_disk_buffer = 0;
Re: [2/2] git commit: TS-2116: create buffer_upload temp files with
mode 0600
Posted by James Peach <ja...@me.com>.
On Aug 22, 2013, at 12:18 AM, Igor Galić <i....@brainsware.org> wrote:
>
>
> ----- Original Message -----
>> TS-2116: create buffer_upload temp files with mode 0600
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/36059e20
>> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/36059e20
>> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/36059e20
>>
>> Branch: refs/heads/master
>> Commit: 36059e207307e90be17871ba5ddeb72ceecc4193
>> Parents: 87ccd26
>> Author: James Peach <jp...@apache.org>
>> Authored: Wed Aug 21 16:00:41 2013 -0700
>> Committer: James Peach <jp...@apache.org>
>> Committed: Wed Aug 21 16:01:13 2013 -0700
>>
>> ----------------------------------------------------------------------
>> plugins/experimental/buffer_upload/buffer_upload.cc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/36059e20/plugins/experimental/buffer_upload/buffer_upload.cc
>> ----------------------------------------------------------------------
>> diff --git a/plugins/experimental/buffer_upload/buffer_upload.cc
>> b/plugins/experimental/buffer_upload/buffer_upload.cc
>> index ae82135..fc496e4 100644
>> --- a/plugins/experimental/buffer_upload/buffer_upload.cc
>> +++ b/plugins/experimental/buffer_upload/buffer_upload.cc
>> @@ -916,7 +916,7 @@ attach_pvc_plugin(TSCont /* contp ATS_UNUSED */, TSEvent
>> event, void *edata)
>> my_state->filename = tempnam(path, NULL);
>> TSDebug(DEBUG_TAG, "temp filename: %s", my_state->filename);
>>
>> - my_state->fd = open(my_state->filename, O_RDWR | O_NONBLOCK | O_TRUNC
>> | O_CREAT);
>> + my_state->fd = open(my_state->filename, O_RDWR | O_NONBLOCK | O_TRUNC
>> | O_CREAT, 0600);
>> if (my_state->fd < 0) {
>> LOG_ERROR("open");
>> uconfig->use_disk_buffer = 0;
>>
>
>
> reminder, there's still this beauty here: https://issues.apache.org/jira/browse/TS-2115
Yup, I only made this change because it broke the build farm :)
J
Re: [2/2] git commit: TS-2116: create buffer_upload temp files with
mode 0600
Posted by Igor Galić <i....@brainsware.org>.
----- Original Message -----
> TS-2116: create buffer_upload temp files with mode 0600
>
>
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/36059e20
> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/36059e20
> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/36059e20
>
> Branch: refs/heads/master
> Commit: 36059e207307e90be17871ba5ddeb72ceecc4193
> Parents: 87ccd26
> Author: James Peach <jp...@apache.org>
> Authored: Wed Aug 21 16:00:41 2013 -0700
> Committer: James Peach <jp...@apache.org>
> Committed: Wed Aug 21 16:01:13 2013 -0700
>
> ----------------------------------------------------------------------
> plugins/experimental/buffer_upload/buffer_upload.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/36059e20/plugins/experimental/buffer_upload/buffer_upload.cc
> ----------------------------------------------------------------------
> diff --git a/plugins/experimental/buffer_upload/buffer_upload.cc
> b/plugins/experimental/buffer_upload/buffer_upload.cc
> index ae82135..fc496e4 100644
> --- a/plugins/experimental/buffer_upload/buffer_upload.cc
> +++ b/plugins/experimental/buffer_upload/buffer_upload.cc
> @@ -916,7 +916,7 @@ attach_pvc_plugin(TSCont /* contp ATS_UNUSED */, TSEvent
> event, void *edata)
> my_state->filename = tempnam(path, NULL);
> TSDebug(DEBUG_TAG, "temp filename: %s", my_state->filename);
>
> - my_state->fd = open(my_state->filename, O_RDWR | O_NONBLOCK | O_TRUNC
> | O_CREAT);
> + my_state->fd = open(my_state->filename, O_RDWR | O_NONBLOCK | O_TRUNC
> | O_CREAT, 0600);
> if (my_state->fd < 0) {
> LOG_ERROR("open");
> uconfig->use_disk_buffer = 0;
>
reminder, there's still this beauty here: https://issues.apache.org/jira/browse/TS-2115
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE