You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ko...@apache.org on 2023/02/21 20:27:48 UTC

[arrow] branch main updated: GH-34271: [C++] Remove Thrift GitHub archive source url (#34273)

This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new ac8e093505 GH-34271: [C++] Remove Thrift GitHub archive source url (#34273)
ac8e093505 is described below

commit ac8e093505036889f02e6a37de6c1aa629ddb359
Author: Jin Shang <sh...@gmail.com>
AuthorDate: Wed Feb 22 04:27:41 2023 +0800

    GH-34271: [C++] Remove Thrift GitHub archive source url (#34273)
    
    Thirft's [GitHub release files](https://github.com/apache/thrift/releases) do not match the checksum of official source files.
    
    > The assets listed below are added by Github based on the release tag and they will therefore not match the checkums published on the Thrift project website.
    
    Using it as Thrift_SOURCE_URL causes issues such as https://github.com/apache/arrow/issues/34271.
    * Closes: #34271
    
    Authored-by: Jin Shang <sh...@gmail.com>
    Signed-off-by: Sutou Kouhei <ko...@clear-code.com>
---
 cpp/cmake_modules/ThirdpartyToolchain.cmake | 1 -
 1 file changed, 1 deletion(-)

diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 4d7679f9ab..c345d5a77f 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -758,7 +758,6 @@ else()
   set_urls(THRIFT_SOURCE_URL
            "https://www.apache.org/dyn/closer.cgi?action=download&filename=/thrift/${ARROW_THRIFT_BUILD_VERSION}/thrift-${ARROW_THRIFT_BUILD_VERSION}.tar.gz"
            "https://downloads.apache.org/thrift/${ARROW_THRIFT_BUILD_VERSION}/thrift-${ARROW_THRIFT_BUILD_VERSION}.tar.gz"
-           "https://github.com/apache/thrift/archive/v${ARROW_THRIFT_BUILD_VERSION}.tar.gz"
            "https://apache.claz.org/thrift/${ARROW_THRIFT_BUILD_VERSION}/thrift-${ARROW_THRIFT_BUILD_VERSION}.tar.gz"
            "https://apache.cs.utah.edu/thrift/${ARROW_THRIFT_BUILD_VERSION}/thrift-${ARROW_THRIFT_BUILD_VERSION}.tar.gz"
            "https://apache.mirrors.lucidnetworks.net/thrift/${ARROW_THRIFT_BUILD_VERSION}/thrift-${ARROW_THRIFT_BUILD_VERSION}.tar.gz"