You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2022/09/08 10:43:42 UTC
[superset] branch master updated: test: Fix act errors in SaveDatasetActionButton test (#21362)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 3fd0ba7b04 test: Fix act errors in SaveDatasetActionButton test (#21362)
3fd0ba7b04 is described below
commit 3fd0ba7b04a3309cc02769dbd48a698279463e95
Author: Lyndsi Kay Williams <55...@users.noreply.github.com>
AuthorDate: Thu Sep 8 05:43:16 2022 -0500
test: Fix act errors in SaveDatasetActionButton test (#21362)
---
.../SaveDatasetActionButton/SaveDatasetActionButton.test.tsx | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/superset-frontend/src/SqlLab/components/SaveDatasetActionButton/SaveDatasetActionButton.test.tsx b/superset-frontend/src/SqlLab/components/SaveDatasetActionButton/SaveDatasetActionButton.test.tsx
index d6e0d7aa6c..316404e3e4 100644
--- a/superset-frontend/src/SqlLab/components/SaveDatasetActionButton/SaveDatasetActionButton.test.tsx
+++ b/superset-frontend/src/SqlLab/components/SaveDatasetActionButton/SaveDatasetActionButton.test.tsx
@@ -29,7 +29,7 @@ const overlayMenu = (
);
describe('SaveDatasetActionButton', () => {
- it('renders a split save button', () => {
+ test('renders a split save button', async () => {
render(
<SaveDatasetActionButton
setShowSave={() => true}
@@ -40,11 +40,14 @@ describe('SaveDatasetActionButton', () => {
const saveBtn = screen.getByRole('button', { name: /save/i });
const caretBtn = screen.getByRole('button', { name: /caret-down/i });
+ expect(
+ await screen.findByRole('button', { name: /save/i }),
+ ).toBeInTheDocument();
expect(saveBtn).toBeVisible();
expect(caretBtn).toBeVisible();
});
- it('renders a "save dataset" dropdown menu item when user clicks caret button', () => {
+ test('renders a "save dataset" dropdown menu item when user clicks caret button', async () => {
render(
<SaveDatasetActionButton
setShowSave={() => true}
@@ -53,6 +56,9 @@ describe('SaveDatasetActionButton', () => {
);
const caretBtn = screen.getByRole('button', { name: /caret-down/i });
+ expect(
+ await screen.findByRole('button', { name: /caret-down/i }),
+ ).toBeInTheDocument();
userEvent.click(caretBtn);
const saveDatasetMenuItem = screen.getByText(/save dataset/i);