You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/05/11 23:32:47 UTC
Review Request 59219: Removed code for old agents in agent
re-registration logic.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59219/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-6977
https://issues.apache.org/jira/browse/MESOS-6977
Repository: mesos
Description
-------
0.x agents are no longer supported.
Diffs
-----
src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
Diff: https://reviews.apache.org/r/59219/diff/1/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 59219: Removed logic for handling missing
FrameworkID in ExecutorInfo.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59219/#review176394
-----------------------------------------------------------
Ship it!
src/master/master.cpp
Line 7564 (original), 7564 (patched)
<https://reviews.apache.org/r/59219/#comment249764>
Maybe a comment that the master validates this when tasks are launched?
- Benjamin Mahler
On May 16, 2017, 8:36 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59219/
> -----------------------------------------------------------
>
> (Updated May 16, 2017, 8:36 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6977
> https://issues.apache.org/jira/browse/MESOS-6977
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The master will inject missing `FrameworkID`s into `ExecutorInfo` since
> Mesos 0.23 (see MESOS-2290), so it should be safe to assume it is always
> set.
>
>
> Diffs
> -----
>
> src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
>
>
> Diff: https://reviews.apache.org/r/59219/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 59219: Removed logic for handling missing
FrameworkID in ExecutorInfo.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59219/
-----------------------------------------------------------
(Updated May 31, 2017, 6:27 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-6977
https://issues.apache.org/jira/browse/MESOS-6977
Repository: mesos
Description
-------
The master will inject missing `FrameworkID`s into `ExecutorInfo` since
Mesos 0.23 (see MESOS-2290), so it should be safe to assume it is always
set.
Diffs (updated)
-----
src/master/master.cpp 14007e08f509446005423e223d5dd76a70744e27
Diff: https://reviews.apache.org/r/59219/diff/3/
Changes: https://reviews.apache.org/r/59219/diff/2-3/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 59219: Removed logic for handling missing
FrameworkID in ExecutorInfo.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59219/
-----------------------------------------------------------
(Updated May 16, 2017, 8:36 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Update description.
Summary (updated)
-----------------
Removed logic for handling missing FrameworkID in ExecutorInfo.
Bugs: MESOS-6977
https://issues.apache.org/jira/browse/MESOS-6977
Repository: mesos
Description (updated)
-------
The master will inject missing `FrameworkID`s into `ExecutorInfo` since
Mesos 0.23 (see MESOS-2290), so it should be safe to assume it is always
set.
Diffs (updated)
-----
src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
Diff: https://reviews.apache.org/r/59219/diff/2/
Changes: https://reviews.apache.org/r/59219/diff/1-2/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 59219: Removed code for old agents in agent
re-registration logic.
Posted by Neil Conway <ne...@gmail.com>.
> On May 12, 2017, 9:40 p.m., Benjamin Mahler wrote:
> > src/master/master.cpp
> > Lines 7564-7573 (original), 7564 (patched)
> > <https://reviews.apache.org/r/59219/diff/1/?file=1716308#file1716308line7564>
> >
> > Hm.. this seems to refer to the scheduler driver rather than a slave version?
Ah, true -- the comment's wording confused me. This validation was moved to the master 2 years ago: https://reviews.apache.org/r/30952/
Since the master has added missing `FrameworkID`s to `Launch` messages since Mesos 0.23, it should be safe to assume the `FrameworkID` is set in `ExecutorInfo`.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59219/#review174860
-----------------------------------------------------------
On May 11, 2017, 11:32 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59219/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 11:32 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6977
> https://issues.apache.org/jira/browse/MESOS-6977
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 0.x agents are no longer supported.
>
>
> Diffs
> -----
>
> src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
>
>
> Diff: https://reviews.apache.org/r/59219/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 59219: Removed code for old agents in agent
re-registration logic.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59219/#review174860
-----------------------------------------------------------
src/master/master.cpp
Lines 7564-7573 (original), 7564 (patched)
<https://reviews.apache.org/r/59219/#comment248080>
Hm.. this seems to refer to the scheduler driver rather than a slave version?
- Benjamin Mahler
On May 11, 2017, 11:32 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59219/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 11:32 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6977
> https://issues.apache.org/jira/browse/MESOS-6977
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 0.x agents are no longer supported.
>
>
> Diffs
> -----
>
> src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
>
>
> Diff: https://reviews.apache.org/r/59219/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 59219: Removed code for old agents in agent
re-registration logic.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59219/#review174836
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59213, 59214, 59215, 59216, 59217, 59218, 59219]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 11, 2017, 11:32 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59219/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 11:32 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6977
> https://issues.apache.org/jira/browse/MESOS-6977
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 0.x agents are no longer supported.
>
>
> Diffs
> -----
>
> src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
>
>
> Diff: https://reviews.apache.org/r/59219/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>