You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "CollinEMac (via GitHub)" <gi...@apache.org> on 2024/01/05 22:13:12 UTC
[I] Only able to import/export Charts, Databases, Datasets, and Dashboards via Versioned Export [superset]
CollinEMac opened a new issue, #26417:
URL: https://github.com/apache/superset/issues/26417
Do to [this change](https://github.com/apache/superset/pull/20368/files), imports/exports are hidden from the user when `VERSIONED_EXPORT` is set to `False`. My team requires the ability to allow users to do a non-versioned export and import.
There have been a few questions about this issue before but it doesn't look like there is currently an open issue:
1. https://github.com/apache/superset/pull/20368#issuecomment-1185671671
2. https://github.com/apache/superset/issues/21001#issuecomment-1523029905
#### How to reproduce the bug
1. Set `VERSIONED_EXPORT` to `False` in your config. (it's `True` by default)
2. Go to import or export a Charts, Databases, Datasets, or Dashboards.
3. The import/export button isn't where it normally would be.
### Expected results
I'd expect to be able to import and export as a `JSON` file when `VERSIONED_EXPORT` is turned off.
### Actual results
The import/export button doesn't display.
#### Screenshots
##### What I'd expect to see (export)
##### What I actually see (export)
##### What I'd expect to see (import)
<img width="1271" alt="Screenshot 2024-01-05 at 4 08 47 PM" src="https://github.com/apache/superset/assets/26743613/446ffa07-3079-4ab6-a001-c3a9bffb9e53">
##### What I actually see (import)
<img width="1271" alt="Screenshot 2024-01-05 at 4 08 55 PM" src="https://github.com/apache/superset/assets/26743613/09ca3845-9c57-416c-87f1-31e3c687802c">
### Environment
- browser type and version: Any
- superset version: `2.1.0` (Issue is present in latest - 3.1.0 as well)
- python version: `3.8` (Issue doesn't depend on python version though)
- node.js version: `20` (Issue doesn't depend on node version though)
- any feature flags active: VERSIONED_EXPORT
### Checklist
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Worth noting that prior to Superset version 2.0, exporting and importing was available when versioned or non-versioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Cannot import/export Charts, Databases, Datasets, and Dashboards with VERSIONED_EXPORT=False [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina closed issue #26417: Cannot import/export Charts, Databases, Datasets, and Dashboards with VERSIONED_EXPORT=False
URL: https://github.com/apache/superset/issues/26417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Only able to import/export Charts, Databases, Datasets, and Dashboards via Versioned Export [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina closed issue #26417: Only able to import/export Charts, Databases, Datasets, and Dashboards via Versioned Export
URL: https://github.com/apache/superset/issues/26417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Cannot import/export Charts, Databases, Datasets, and Dashboards with VERSIONED_EXPORT=False [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on issue #26417:
URL: https://github.com/apache/superset/issues/26417#issuecomment-1886065933
If you set `VERSIONED_EXPORT` to true, do you see the export button?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Cannot import/export Charts, Databases, Datasets, and Dashboards with VERSIONED_EXPORT=False [superset]
Posted by "CollinEMac (via GitHub)" <gi...@apache.org>.
CollinEMac commented on issue #26417:
URL: https://github.com/apache/superset/issues/26417#issuecomment-1887930067
Yes, we can see the export button with `VERSIONED_EXPORT` turned on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Cannot import/export Charts, Databases, Datasets, and Dashboards with VERSIONED_EXPORT=False [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #26417:
URL: https://github.com/apache/superset/issues/26417#issuecomment-1912493828
Closing this issue assuming that the export button is visible with VERSIONED_EXPORT turned on and that
> Since we're actively supporting that version, it will be easier for us to address any issues with that feature moving forward rather than supporting the old version.
Please feel free to reopen it if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Cannot import/export Charts, Databases, Datasets, and Dashboards with VERSIONED_EXPORT=False [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on issue #26417:
URL: https://github.com/apache/superset/issues/26417#issuecomment-1883682382
HI @CollinEMac and @vergenzt can I ask what the bugs are that you're finding with the new import/export feature? Since we're actively supporting that version, it will be easier for us to address any issues with that feature moving forward rather than supporting the old version. I saw that one of the bug tickets mentioned missing an export button with the flag turned on. You'll want to also give permissions for `can_export` to see the export button. Is that the main issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Cannot import/export Charts, Databases, Datasets, and Dashboards with VERSIONED_EXPORT=False [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #26417:
URL: https://github.com/apache/superset/issues/26417#issuecomment-1882898942
> @michael-s-molina how do you export dashboards using the legacy feature? That's an important part of the functionality we're missing.
I'm not sure if it's possible. Let me ping some folks with more context about this feature @eschutho @betodealmeida @hughhhh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Cannot import/export Charts, Databases, Datasets, and Dashboards with VERSIONED_EXPORT=False [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on issue #26417:
URL: https://github.com/apache/superset/issues/26417#issuecomment-1886060577
@CollinEMac The `VERSIONED_EXPORT` flag is essentially the v2 functionality for import/export which is more robust, and also why we're deprecating the original version. Is there any functionality in the old version that you don't have in the new one? Or another reason why you're unable to use the latest feature? The new version (`VERSIONED_EXPORT`) has import/export for charts, dashboards, datasets, databases and queries and is backward compatible when importing with the older json exports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Only able to import/export Charts, Databases, Datasets, and Dashboards via Versioned Export [superset]
Posted by "vergenzt (via GitHub)" <gi...@apache.org>.
vergenzt commented on issue #26417:
URL: https://github.com/apache/superset/issues/26417#issuecomment-1881756391
@michael-s-molina how do you *export* dashboards using the legacy feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Only able to import/export Charts, Databases, Datasets, and Dashboards via Versioned Export [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #26417:
URL: https://github.com/apache/superset/issues/26417#issuecomment-1880813351
Hi @CollinEMac. When `VERSIONED_EXPORT` is set to False, you can import dashboards using the legacy feature which is available in the Settings menu.
<img width="247" alt="Screenshot 2024-01-08 at 08 19 31" src="https://github.com/apache/superset/assets/70410625/4ff79f7a-1690-4770-b074-00da5d6d923a">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Cannot import/export Charts, Databases, Datasets, and Dashboards with VERSIONED_EXPORT=False [superset]
Posted by "CollinEMac (via GitHub)" <gi...@apache.org>.
CollinEMac commented on issue #26417:
URL: https://github.com/apache/superset/issues/26417#issuecomment-1883800588
Hi @eschutho,
Yes, our primary concern is that the export button is hidden for dashboards. We've verified that `can_export` is `True`. However, it's required that the `VERSIONED_EXPORT` feature flag is also set to `True` (link to related code below). I'm not sure why versioned export would be required to export a dashboard. This feels like unexpected behavior to me.
https://github.com/apache/superset/blob/2.1.0/superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx#L166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org