You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/03 01:20:22 UTC

[GitHub] cjolivier01 commented on a change in pull request #9940: remove set CMAKE_GENERATOR_TOOLSET

cjolivier01 commented on a change in pull request #9940: remove set CMAKE_GENERATOR_TOOLSET
URL: https://github.com/apache/incubator-mxnet/pull/9940#discussion_r171999786
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -44,16 +44,16 @@ if(USE_CUDA AND NOT USE_OLDCMAKECUDA)
         OR (${CMAKE_GENERATOR} STREQUAL "Unix Makefiles")
       ) AND (
         (${CMAKE_VERSION} VERSION_GREATER "3.9.0") OR (${CMAKE_VERSION} VERSION_EQUAL "3.9.0")
-      )
+      ) AND NOT USE_OLDCMAKECUDA
 
 Review comment:
   I think it makes more sense up top in the old place because this else block just reset it again to false, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services