You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/12/09 13:39:05 UTC

Review Request 41134: AMBARI-14282 : Handle Ranger Admin restart for downgrade from HDP-2.3 to HDP-2.2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41134/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: AMBARI-14282
    https://issues.apache.org/jira/browse/AMBARI-14282


Repository: ambari


Description
-------

Patch contains condion to check upgrade / downgrade scenarios while setting ranger conf directories.


Diffs
-----

  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py d7c0635 

Diff: https://reviews.apache.org/r/41134/diff/


Testing
-------

Tested for following scenarios : 

1) Ranger install via Ambari for HDP-2.2
2) Ranger install via Ambari for HDP-2.3
3) Ranger install via Ambari for HDP-2.2 then upgrade and downgrade from HDP-2.3 

Ranger install / start was  successful.

----------------------------------------------------------------------
Ran 271 tests in 7.935s

OK
----------------------------------------------------------------------
Total run:883
Total errors:0
Total failures:0
OK


Thanks,

Gautam Borad


Re: Review Request 41134: AMBARI-14282 : Handle Ranger Admin restart for downgrade from HDP-2.3 to HDP-2.2

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41134/#review109510
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py (line 62)
<https://reviews.apache.org/r/41134/#comment169080>

    There isnt a check in the code to verify that the stack is 2.2+


- Jayush Luniya


On Dec. 9, 2015, 12:39 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41134/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 12:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14282
>     https://issues.apache.org/jira/browse/AMBARI-14282
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains condion to check upgrade / downgrade scenarios while setting ranger conf directories.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py d7c0635 
> 
> Diff: https://reviews.apache.org/r/41134/diff/
> 
> 
> Testing
> -------
> 
> Tested for following scenarios : 
> 
> 1) Ranger install via Ambari for HDP-2.2
> 2) Ranger install via Ambari for HDP-2.3
> 3) Ranger install via Ambari for HDP-2.2 then upgrade and downgrade from HDP-2.3 
> 
> Ranger install / start was  successful.
> 
> ----------------------------------------------------------------------
> Ran 271 tests in 7.935s
> 
> OK
> ----------------------------------------------------------------------
> Total run:883
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41134: AMBARI-14282 : Handle Ranger Admin restart for downgrade from HDP-2.3 to HDP-2.2

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41134/#review109519
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Dec. 9, 2015, 7:39 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41134/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 7:39 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14282
>     https://issues.apache.org/jira/browse/AMBARI-14282
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains condion to check upgrade / downgrade scenarios while setting ranger conf directories.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py d7c0635 
> 
> Diff: https://reviews.apache.org/r/41134/diff/
> 
> 
> Testing
> -------
> 
> Tested for following scenarios : 
> 
> 1) Ranger install via Ambari for HDP-2.2
> 2) Ranger install via Ambari for HDP-2.3
> 3) Ranger install via Ambari for HDP-2.2 then upgrade and downgrade from HDP-2.3 
> 
> Ranger install / start was  successful.
> 
> ----------------------------------------------------------------------
> Ran 271 tests in 7.935s
> 
> OK
> ----------------------------------------------------------------------
> Total run:883
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41134: AMBARI-14282 : Handle Ranger Admin restart for downgrade from HDP-2.3 to HDP-2.2

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41134/#review109527
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Dec. 9, 2015, 7:39 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41134/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 7:39 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14282
>     https://issues.apache.org/jira/browse/AMBARI-14282
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains condion to check upgrade / downgrade scenarios while setting ranger conf directories.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py d7c0635 
> 
> Diff: https://reviews.apache.org/r/41134/diff/
> 
> 
> Testing
> -------
> 
> Tested for following scenarios : 
> 
> 1) Ranger install via Ambari for HDP-2.2
> 2) Ranger install via Ambari for HDP-2.3
> 3) Ranger install via Ambari for HDP-2.2 then upgrade and downgrade from HDP-2.3 
> 
> Ranger install / start was  successful.
> 
> ----------------------------------------------------------------------
> Ran 271 tests in 7.935s
> 
> OK
> ----------------------------------------------------------------------
> Total run:883
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41134: AMBARI-14282 : Handle Ranger Admin restart for downgrade from HDP-2.3 to HDP-2.2

Posted by Jayush Luniya <jl...@hortonworks.com>.

> On Dec. 9, 2015, 5:46 p.m., Jayush Luniya wrote:
> > Ship It!

Gautam, can you close the review?


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41134/#review109561
-----------------------------------------------------------


On Dec. 9, 2015, 12:39 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41134/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 12:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14282
>     https://issues.apache.org/jira/browse/AMBARI-14282
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains condion to check upgrade / downgrade scenarios while setting ranger conf directories.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py d7c0635 
> 
> Diff: https://reviews.apache.org/r/41134/diff/
> 
> 
> Testing
> -------
> 
> Tested for following scenarios : 
> 
> 1) Ranger install via Ambari for HDP-2.2
> 2) Ranger install via Ambari for HDP-2.3
> 3) Ranger install via Ambari for HDP-2.2 then upgrade and downgrade from HDP-2.3 
> 
> Ranger install / start was  successful.
> 
> ----------------------------------------------------------------------
> Ran 271 tests in 7.935s
> 
> OK
> ----------------------------------------------------------------------
> Total run:883
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41134: AMBARI-14282 : Handle Ranger Admin restart for downgrade from HDP-2.3 to HDP-2.2

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41134/#review109561
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On Dec. 9, 2015, 12:39 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41134/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 12:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14282
>     https://issues.apache.org/jira/browse/AMBARI-14282
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains condion to check upgrade / downgrade scenarios while setting ranger conf directories.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py d7c0635 
> 
> Diff: https://reviews.apache.org/r/41134/diff/
> 
> 
> Testing
> -------
> 
> Tested for following scenarios : 
> 
> 1) Ranger install via Ambari for HDP-2.2
> 2) Ranger install via Ambari for HDP-2.3
> 3) Ranger install via Ambari for HDP-2.2 then upgrade and downgrade from HDP-2.3 
> 
> Ranger install / start was  successful.
> 
> ----------------------------------------------------------------------
> Ran 271 tests in 7.935s
> 
> OK
> ----------------------------------------------------------------------
> Total run:883
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41134: AMBARI-14282 : Handle Ranger Admin restart for downgrade from HDP-2.3 to HDP-2.2

Posted by Jayush Luniya <jl...@hortonworks.com>.

> On Dec. 9, 2015, 2:36 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py, line 62
> > <https://reviews.apache.org/r/41134/diff/1/?file=1157070#file1157070line62>
> >
> >     As such for HDP 2.1 we support only express upgrade from HDP 2.1 -> HDP 2.3. So we should be downgrading to HDP 2.2+. But from the code its not obvious.

Doesnt need to be  addressed.


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41134/#review109511
-----------------------------------------------------------


On Dec. 9, 2015, 12:39 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41134/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 12:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14282
>     https://issues.apache.org/jira/browse/AMBARI-14282
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains condion to check upgrade / downgrade scenarios while setting ranger conf directories.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py d7c0635 
> 
> Diff: https://reviews.apache.org/r/41134/diff/
> 
> 
> Testing
> -------
> 
> Tested for following scenarios : 
> 
> 1) Ranger install via Ambari for HDP-2.2
> 2) Ranger install via Ambari for HDP-2.3
> 3) Ranger install via Ambari for HDP-2.2 then upgrade and downgrade from HDP-2.3 
> 
> Ranger install / start was  successful.
> 
> ----------------------------------------------------------------------
> Ran 271 tests in 7.935s
> 
> OK
> ----------------------------------------------------------------------
> Total run:883
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41134: AMBARI-14282 : Handle Ranger Admin restart for downgrade from HDP-2.3 to HDP-2.2

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41134/#review109511
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py (line 62)
<https://reviews.apache.org/r/41134/#comment169081>

    As such for HDP 2.1 we support only express upgrade from HDP 2.1 -> HDP 2.3. So we should be downgrading to HDP 2.2+. But from the code its not obvious.


- Jayush Luniya


On Dec. 9, 2015, 12:39 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41134/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 12:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14282
>     https://issues.apache.org/jira/browse/AMBARI-14282
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains condion to check upgrade / downgrade scenarios while setting ranger conf directories.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py d7c0635 
> 
> Diff: https://reviews.apache.org/r/41134/diff/
> 
> 
> Testing
> -------
> 
> Tested for following scenarios : 
> 
> 1) Ranger install via Ambari for HDP-2.2
> 2) Ranger install via Ambari for HDP-2.3
> 3) Ranger install via Ambari for HDP-2.2 then upgrade and downgrade from HDP-2.3 
> 
> Ranger install / start was  successful.
> 
> ----------------------------------------------------------------------
> Ran 271 tests in 7.935s
> 
> OK
> ----------------------------------------------------------------------
> Total run:883
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 41134: AMBARI-14282 : Handle Ranger Admin restart for downgrade from HDP-2.3 to HDP-2.2

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41134/#review109577
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Dec. 9, 2015, 12:39 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41134/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 12:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14282
>     https://issues.apache.org/jira/browse/AMBARI-14282
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains condion to check upgrade / downgrade scenarios while setting ranger conf directories.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py d7c0635 
> 
> Diff: https://reviews.apache.org/r/41134/diff/
> 
> 
> Testing
> -------
> 
> Tested for following scenarios : 
> 
> 1) Ranger install via Ambari for HDP-2.2
> 2) Ranger install via Ambari for HDP-2.3
> 3) Ranger install via Ambari for HDP-2.2 then upgrade and downgrade from HDP-2.3 
> 
> Ranger install / start was  successful.
> 
> ----------------------------------------------------------------------
> Ran 271 tests in 7.935s
> 
> OK
> ----------------------------------------------------------------------
> Total run:883
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>