[GitHub] [lucene-solr] nknize commented on issue #726: LUCENE-8632: New XYShape Field and Queries for indexing and searching general cartesian geometries

[GitBox <gi...@apache.org>]

nknize commented on issue #726: LUCENE-8632: New XYShape Field and Queries for indexing and searching general cartesian geometries
URL: https://github.com/apache/lucene-solr/pull/726#issuecomment-509283222
 
 
   Cleaned up the API a bit:
   
   * refactors `Tessellator.Triangle` `getLat / getLon` methods to `getY / getX`, respectively
   * Changed `XYShape.createIndexableFields` and `XYShape.newBoxQuery` to accept floats instead of doubles
   
   Refactored `TestLatLonShapeEncoding` to derive from a new `BaseShapeEncodingTestCase` class along with a new `TestXYShapeEncoding` class to equally test the `XYShapeEncoding` logic.
   
   I think this PR is just about ready to merge and continue iterating in sandbox?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org