[GitHub] [solr] risdenk commented on a diff in pull request #1237: SOLR-16586: Log start of SearchHandler#handleRequestBody

[GitBox <gi...@apache.org>]

risdenk commented on code in PR #1237:
URL: https://github.com/apache/solr/pull/1237#discussion_r1047382150


##########
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##########
@@ -326,6 +326,9 @@ protected ResponseBuilder newResponseBuilder(
 
   @Override
   public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throws Exception {
+    if (log.isInfoEnabled()) {
+      log.info("Start Search Query: {}", req.getParamString());
+    }

Review Comment:
   Not sure I'm a fan of this approach. This could have some huge implications on logging requirements and storage. This is logging every single request right?
   
   Previously it looks like this was logged only for timeouts:
   
   ```
   } catch (ExitableDirectoryReader.ExitingReaderException ex) {
           log.warn("Query: {}; ", req.getParamString(), ex);
   ```
   
   This should at least be disabled by default. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org