You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/09/05 22:15:09 UTC
Review Request 68636: Reserved vector capacities within Master::offer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68636/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Meng Zhu.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/master.cpp e307df001fba3afbd128c3c0d9db955d6777186a
Diff: https://reviews.apache.org/r/68636/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 68636: Reserved vector capacities within
Master::offer.
Posted by Benjamin Mahler <bm...@apache.org>.
> On Sept. 6, 2018, 12:41 a.m., Meng Zhu wrote:
> > src/master/master.cpp
> > Lines 9249 (patched)
> > <https://reviews.apache.org/r/68636/diff/1/?file=2082765#file2082765line9249>
> >
> > can you put the type here instead of `auto`?
Unfortunately templated types don't work inside `foreach(|key|value)`, I would need a typedef.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68636/#review208387
-----------------------------------------------------------
On Sept. 5, 2018, 10:15 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68636/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2018, 10:15 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp e307df001fba3afbd128c3c0d9db955d6777186a
>
>
> Diff: https://reviews.apache.org/r/68636/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 68636: Reserved vector capacities within
Master::offer.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68636/#review208387
-----------------------------------------------------------
Ship it!
src/master/master.cpp
Lines 9249 (patched)
<https://reviews.apache.org/r/68636/#comment292280>
can you put the type here instead of `auto`?
- Meng Zhu
On Sept. 5, 2018, 3:15 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68636/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2018, 3:15 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp e307df001fba3afbd128c3c0d9db955d6777186a
>
>
> Diff: https://reviews.apache.org/r/68636/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>