You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by mt...@apache.org on 2007/05/08 19:44:16 UTC
svn commit: r536272 - /httpd/httpd/branches/2.2.x/STATUS
Author: mturk
Date: Tue May 8 10:44:15 2007
New Revision: 536272
URL: http://svn.apache.org/viewvc?view=rev&rev=536272
Log:
Ups. Filed under wrong chapter. Sorry :)
Modified:
httpd/httpd/branches/2.2.x/STATUS
Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?view=diff&rev=536272&r1=536271&r2=536272
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Tue May 8 10:44:15 2007
@@ -77,10 +77,6 @@
PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
[ start all new proposals below, under PATCHES PROPOSED. ]
- * ApacheMonitor: Fix Windows Vista detection.
- http://svn.apache.org/viewvc?view=rev&revision=536052
- +1: mturk
-
* mod_cache: Correctly cache objects whose URL query string has been
modified by mod_rewrite.
PR: 40805
@@ -112,6 +108,10 @@
PATCHES PROPOSED TO BACKPORT FROM TRUNK:
+ * ApacheMonitor: Fix Windows Vista detection.
+ http://svn.apache.org/viewvc?view=rev&revision=536052
+ +1: mturk
+
* mpm_winnt: Fix return values from wait_for_many_objects.
Note - this is required to avoid hangups of socket #64, #128
as Microsoft set aside 64 reserved values.
Re: svn commit: r536272 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Mladen Turk <mt...@apache.org>.
William A. Rowe, Jr. wrote:
>
> You want to commit or should I?
>
Knock yourself out :)
Cheers,
Mladen.
Re: svn commit: r536272 - /httpd/httpd/branches/2.2.x/STATUS
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Mladen Turk wrote:
> William A. Rowe, Jr. wrote:
>> Can't we do
>>
>> + else if (osvi.dwMajorVersion >= 6) {
>> + *dwVersion = OS_VERSION_VISTA;
>>
>> for now (or simply 'else') so that this isn't instantly broken by the
>> next version, irrespective of any changes required?
>>
>
> Sure we can. Since we are only interested in the post NT4
> we can even make test for >= 5
> However, who knows what future versions will came up with :)
Fine - if it breaks it breaks, but not because we "pre broke" the damned thing
:)
You want to commit or should I?
Bill
Re: svn commit: r536272 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Mladen Turk <mt...@apache.org>.
William A. Rowe, Jr. wrote:
> Can't we do
>
> + else if (osvi.dwMajorVersion >= 6) {
> + *dwVersion = OS_VERSION_VISTA;
>
> for now (or simply 'else') so that this isn't instantly broken by the
> next version, irrespective of any changes required?
>
Sure we can. Since we are only interested in the post NT4
we can even make test for >= 5
However, who knows what future versions will came up with :)
Regards,
Mladen.
Re: svn commit: r536272 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Mladen Turk <mt...@apache.org>.
William A. Rowe, Jr. wrote:
> Can't we do
>
> + else if (osvi.dwMajorVersion >= 6) {
> + *dwVersion = OS_VERSION_VISTA;
>
> for now (or simply 'else') so that this isn't instantly broken by the
> next version, irrespective of any changes required?
>
Nevertheless, completely unrelated ...
While testing Vista support I found out that the installer
allows the installation although the httpd.conf is missing.
However, the httpd -k unistall breaks because it first tests
the presence of the httpd.conf, so one cannot uninstall the
httpd service if there is no valid httpd.conf. Even if the
httpd.conf is present, and it fails the httpd -T, uninstall
doesn't work. Only the valid httpd.conf allows service uninstall.
Think we should address those issues cause
IMHO, unistall should always work if there is something
installed. At lest it should remove the service, or even
better, the service should not be installed unless we have
a valid httpd that can be run from the SCM.
Regards,
Mladen.
Re: svn commit: r536272 - /httpd/httpd/branches/2.2.x/STATUS
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Can't we do
+ else if (osvi.dwMajorVersion >= 6) {
+ *dwVersion = OS_VERSION_VISTA;
for now (or simply 'else') so that this isn't instantly broken by the
next version, irrespective of any changes required?
Bill
mturk@apache.org wrote:
> Author: mturk
> Date: Tue May 8 10:44:15 2007
> New Revision: 536272
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=536272
> Log:
> Ups. Filed under wrong chapter. Sorry :)
>
> Modified:
> httpd/httpd/branches/2.2.x/STATUS
>
> Modified: httpd/httpd/branches/2.2.x/STATUS
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?view=diff&rev=536272&r1=536271&r2=536272
> ==============================================================================
> --- httpd/httpd/branches/2.2.x/STATUS (original)
> +++ httpd/httpd/branches/2.2.x/STATUS Tue May 8 10:44:15 2007
> @@ -77,10 +77,6 @@
> PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
> [ start all new proposals below, under PATCHES PROPOSED. ]
>
> - * ApacheMonitor: Fix Windows Vista detection.
> - http://svn.apache.org/viewvc?view=rev&revision=536052
> - +1: mturk
> -
> * mod_cache: Correctly cache objects whose URL query string has been
> modified by mod_rewrite.
> PR: 40805
> @@ -112,6 +108,10 @@
>
> PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>
> + * ApacheMonitor: Fix Windows Vista detection.
> + http://svn.apache.org/viewvc?view=rev&revision=536052
> + +1: mturk
> +
> * mpm_winnt: Fix return values from wait_for_many_objects.
> Note - this is required to avoid hangups of socket #64, #128
> as Microsoft set aside 64 reserved values.
>
>
>
>
Re: svn commit: r536272 - /httpd/httpd/branches/2.2.x/STATUS
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Can't we do
+ else if (osvi.dwMajorVersion >= 6) {
+ *dwVersion = OS_VERSION_VISTA;
for now (or simply 'else') so that this isn't instantly broken by the
next version, irrespective of any changes required?
Bill
mturk@apache.org wrote:
> Author: mturk
> Date: Tue May 8 10:44:15 2007
> New Revision: 536272
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=536272
> Log:
> Ups. Filed under wrong chapter. Sorry :)
>
> Modified:
> httpd/httpd/branches/2.2.x/STATUS
>
> Modified: httpd/httpd/branches/2.2.x/STATUS
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?view=diff&rev=536272&r1=536271&r2=536272
> ==============================================================================
> --- httpd/httpd/branches/2.2.x/STATUS (original)
> +++ httpd/httpd/branches/2.2.x/STATUS Tue May 8 10:44:15 2007
> @@ -77,10 +77,6 @@
> PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
> [ start all new proposals below, under PATCHES PROPOSED. ]
>
> - * ApacheMonitor: Fix Windows Vista detection.
> - http://svn.apache.org/viewvc?view=rev&revision=536052
> - +1: mturk
> -
> * mod_cache: Correctly cache objects whose URL query string has been
> modified by mod_rewrite.
> PR: 40805
> @@ -112,6 +108,10 @@
>
> PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>
> + * ApacheMonitor: Fix Windows Vista detection.
> + http://svn.apache.org/viewvc?view=rev&revision=536052
> + +1: mturk
> +
> * mpm_winnt: Fix return values from wait_for_many_objects.
> Note - this is required to avoid hangups of socket #64, #128
> as Microsoft set aside 64 reserved values.
>
>
>
>