[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9857: #9834 Added Delete Schema/Table pinot admin commands

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #9857:
URL: https://github.com/apache/pinot/pull/9857#discussion_r1034110579


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java:
##########
@@ -236,6 +238,27 @@ public static URI getUploadSchemaURI(String protocol, String host, int port)
     return getURI(protocol, host, port, SCHEMA_PATH);
   }
 
+  public static URI getDeleteSchemaURI(String protocol, String host, int port, String schemaName)
+      throws URISyntaxException {
+    return getURI(protocol, host, port, SCHEMA_PATH + "/" + schemaName);
+  }
+
+  public static URI getDeleteTableURI(String protocol, String host, int port, String tableName, String type,
+      String retention)
+      throws URISyntaxException {
+    StringBuilder sb = new StringBuilder();
+    if (StringUtils.isNotBlank(type)) {
+      sb.append(TYPE_DELIMITER);
+      sb.append(type);
+    }
+    if (StringUtils.isNotBlank(retention)) {
+      sb.append(RETENTION_PARAMETER);

Review Comment:
   If type is not provided, we should not add `&` for the retention



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org