You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/23 09:51:48 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #9634: [database] Fix, test connection error message for module not found
dpgaspar opened a new pull request #9634:
URL: https://github.com/apache/incubator-superset/pull/9634
### CATEGORY
- [X] Bug Fix
- [X] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
When the connection scheme is composed by 2 elements "<type>+<drivername>://...." the error reported to the user is "Unexpected error occurred, please check your logs for details" and should be "Could not load database driver: ..."
### TEST PLAN
- Create a database connection with: `something+dummy://someserver:9999/test`
- Check that the error reported is "ERROR: Could not load database driver: something+dummy"
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar edited a comment on pull request #9634: [database] Fix, test connection error message for module not found
Posted by GitBox <gi...@apache.org>.
dpgaspar edited a comment on pull request #9634:
URL: https://github.com/apache/incubator-superset/pull/9634#issuecomment-619022719
@villebro
Yes caught this while testing MSSQL, so used:
`mssql+pymssql://sa:XXXXXXXXXX@localhost:1433/msdb`
You can reproduce it by removing the pymssql from the virtualenv
You're right thought my assumption is not totally correct, updated the PR description
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on pull request #9634: [database] Fix, test connection error message for module not found
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #9634:
URL: https://github.com/apache/incubator-superset/pull/9634#issuecomment-619022719
Yes caught this while testing MSSQL, so used:
`mssql+pymssql://sa:XXXXXXXXXX@localhost:1433/msdb`
You can reproduce it by removing the pymssql from the virtualenv
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar edited a comment on pull request #9634: [database] Fix, test connection error message for module not found
Posted by GitBox <gi...@apache.org>.
dpgaspar edited a comment on pull request #9634:
URL: https://github.com/apache/incubator-superset/pull/9634#issuecomment-619022719
@villebro
Yes caught this while testing MSSQL, so used:
`mssql+pymssql://sa:XXXXXXXXXX@localhost:1433/msdb`
You can reproduce it by removing the pymssql from the virtualenv
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9634: [database] Fix, test connection error message for module not found
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9634:
URL: https://github.com/apache/incubator-superset/pull/9634#issuecomment-618572312
Would it be possible to add a test for this case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9634: [database] Fix, test connection error message for module not found
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9634:
URL: https://github.com/apache/incubator-superset/pull/9634#issuecomment-619017264
Hmm, I wasn't able to reproduce with the test string `something+dummy://someserver:9999/test`. Were you testing a specific driver when this came up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar edited a comment on pull request #9634: [database] Fix, test connection error message for module not found
Posted by GitBox <gi...@apache.org>.
dpgaspar edited a comment on pull request #9634:
URL: https://github.com/apache/incubator-superset/pull/9634#issuecomment-619022719
@villebro
Yes caught this while testing MSSQL, so used:
`mssql+pymssql://sa:XXXXXXXXXX@localhost:1433/msdb`
You can reproduce it by removing the pymssql from the virtualenv
Yet, you're right, my assumption is not totally correct, updated the PR description
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar edited a comment on pull request #9634: [database] Fix, test connection error message for module not found
Posted by GitBox <gi...@apache.org>.
dpgaspar edited a comment on pull request #9634:
URL: https://github.com/apache/incubator-superset/pull/9634#issuecomment-619022719
@villebro
Caught this while testing MSSQL, so used:
`mssql+pymssql://sa:XXXXXXXXXX@localhost:1433/msdb`
You can reproduce it by removing the pymssql from the virtualenv
Yet, you're right, my assumption is not totally correct, updated the PR description
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org