You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "amichair (via GitHub)" <gi...@apache.org> on 2026/05/25 18:08:51 UTC
[PR] Zookeeper fastbin tck [aries-rsa]
amichair opened a new pull request, #119:
URL: https://github.com/apache/aries-rsa/pull/119
Includes the fixes necessary for the zookeeper discovery and fastbin providers to pass the TCK tests.
Regarding the commit fixing fastbin not shutting down properly, if you have a more elegant way of solving this please do share... (I have no previous experience with hawtdispatch).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add TCK test run with ZooKeeper discovery and Fastbin distribution provider [aries-rsa]
Posted by "amichair (via GitHub)" <gi...@apache.org>.
amichair commented on code in PR #119:
URL: https://github.com/apache/aries-rsa/pull/119#discussion_r3315832074
##########
provider/fastbin/src/main/java/org/apache/aries/rsa/provider/fastbin/FastBinProvider.java:
##########
@@ -50,6 +57,8 @@ public class FastBinProvider implements DistributionProvider {
private static final Logger LOG = LoggerFactory.getLogger(FastBinProvider.class);
+ static final String[] SUPPORTED_INTENTS = { "tck.test" }; // at least one intent required by TCK
Review Comment:
Hmmm... the field itself is not the default empty intents, but all currently supported intents (if we wanted to add one, we would just add it to this array, not rename the array or add another array), so I think it's current name is correct. It just so happens that we currently support only one dummy intent, necessary for the TCK but a no-op otherwise. I'm not even sure it should be in a javadoc - it's an internal implementation detail that should not be public-facing and may be removed in the future if they fix the TCK test. There is no way to make the distinction between a 'public javadoc' and 'private javadoc', so we either consider the whole javadoc private or separate the public javadoc (just "All intents supported by this provider" and an implementation-detail comment similar to the existing one just so maintainers won't remove this unintuitive no-op string. What do you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add TCK test run with ZooKeeper discovery and Fastbin distribution provider [aries-rsa]
Posted by "amichair (via GitHub)" <gi...@apache.org>.
amichair commented on code in PR #119:
URL: https://github.com/apache/aries-rsa/pull/119#discussion_r3306582299
##########
provider/fastbin/src/main/java/org/apache/aries/rsa/provider/fastbin/FastBinProvider.java:
##########
@@ -50,6 +57,8 @@ public class FastBinProvider implements DistributionProvider {
private static final Logger LOG = LoggerFactory.getLogger(FastBinProvider.class);
+ static final String[] SUPPORTED_INTENTS = { "tck.test" }; // at least one intent required by TCK
Review Comment:
No, it's a dummy value, I just picked something that's clear it's related to the tck test and obviously not a real one. If you have a better suggestion I'll change it, it doesn't really matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add TCK test run with ZooKeeper discovery and Fastbin distribution provider [aries-rsa]
Posted by "amichair (via GitHub)" <gi...@apache.org>.
amichair commented on code in PR #119:
URL: https://github.com/apache/aries-rsa/pull/119#discussion_r3325331398
##########
provider/fastbin/src/main/java/org/apache/aries/rsa/provider/fastbin/FastBinProvider.java:
##########
@@ -50,6 +57,8 @@ public class FastBinProvider implements DistributionProvider {
private static final Logger LOG = LoggerFactory.getLogger(FastBinProvider.class);
+ static final String[] SUPPORTED_INTENTS = { "tck.test" }; // at least one intent required by TCK
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add TCK test run with ZooKeeper discovery and Fastbin distribution provider [aries-rsa]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on code in PR #119:
URL: https://github.com/apache/aries-rsa/pull/119#discussion_r3319815465
##########
provider/fastbin/src/main/java/org/apache/aries/rsa/provider/fastbin/FastBinProvider.java:
##########
@@ -50,6 +57,8 @@ public class FastBinProvider implements DistributionProvider {
private static final Logger LOG = LoggerFactory.getLogger(FastBinProvider.class);
+ static final String[] SUPPORTED_INTENTS = { "tck.test" }; // at least one intent required by TCK
Review Comment:
I think that's easier to keep javadoc then the standard comments and it's easier to see it in the IDE when used. I would recommend to add the javadoc and let's merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add TCK test run with ZooKeeper discovery and Fastbin distribution provider [aries-rsa]
Posted by "amichair (via GitHub)" <gi...@apache.org>.
amichair merged PR #119:
URL: https://github.com/apache/aries-rsa/pull/119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add TCK test run with ZooKeeper discovery and Fastbin distribution provider [aries-rsa]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on code in PR #119:
URL: https://github.com/apache/aries-rsa/pull/119#discussion_r3306735371
##########
provider/fastbin/src/main/java/org/apache/aries/rsa/provider/fastbin/FastBinProvider.java:
##########
@@ -50,6 +57,8 @@ public class FastBinProvider implements DistributionProvider {
private static final Logger LOG = LoggerFactory.getLogger(FastBinProvider.class);
+ static final String[] SUPPORTED_INTENTS = { "tck.test" }; // at least one intent required by TCK
Review Comment:
maybe?
```
static final String[] DEFAULT_NOT_EMPTY_INTENTS = { "aries.rsa.default" };
```
BTW we should make the comment a javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add TCK test run with ZooKeeper discovery and Fastbin distribution provider [aries-rsa]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on code in PR #119:
URL: https://github.com/apache/aries-rsa/pull/119#discussion_r3305904270
##########
provider/fastbin/src/main/java/org/apache/aries/rsa/provider/fastbin/FastBinProvider.java:
##########
@@ -50,6 +57,8 @@ public class FastBinProvider implements DistributionProvider {
private static final Logger LOG = LoggerFactory.getLogger(FastBinProvider.class);
+ static final String[] SUPPORTED_INTENTS = { "tck.test" }; // at least one intent required by TCK
Review Comment:
is exactly the value `tck.test` necessary? or should we use some placeholder value specific for our implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org