You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2014/10/09 07:36:55 UTC
Re: Review Request 26168: There are new VM State Machine changes
introduced which were missed to capture the usage events
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26168/
-----------------------------------------------------------
(Updated Oct. 9, 2014, 5:36 a.m.)
Review request for cloudstack, Kishan Kavala and Koushik Das.
Changes
-------
Incorporated comments from Koushik
Bugs: CLOUDSTACK-7648
https://issues.apache.org/jira/browse/CLOUDSTACK-7648
Repository: cloudstack-git
Description
-------
There are new VM State Machine changes introduced while adding VM Sync changes and these were missed to capture the usage events.
This is causing to get wrong usage statistics for a VM who's state is changed by VM sync
Diffs (updated)
-----
api/src/com/cloud/vm/VirtualMachine.java 34387eb
engine/components-api/src/com/cloud/network/NetworkStateListener.java c86f782
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java 92163ea
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java c998e3b
server/src/com/cloud/capacity/CapacityManagerImpl.java e5b7d19
server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java a40a7d7
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 968c538
server/src/com/cloud/network/security/SecurityGroupManagerImpl.java f60a746
server/src/com/cloud/storage/listener/SnapshotStateListener.java 8da71a6
server/src/com/cloud/storage/listener/VolumeStateListener.java 1911a48
server/src/com/cloud/vm/UserVmStateListener.java a0088b8
server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java 8e606ca
utils/src/com/cloud/utils/fsm/StateListener.java 3d0a645
utils/src/com/cloud/utils/fsm/StateMachine2.java 4950a25cb
Diff: https://reviews.apache.org/r/26168/diff/
Testing
-------
Tested on Simulator for all VM Lifecycle states and tested with Xenserver for VM Sync reatled actions.
Ran Simulator for VM lifecycle realted tests.
Currenly there is no API call listUsageEvents to verify that events are generated.
Thanks,
Damodar Reddy Talakanti
Re: Review Request 26168: There are new VM State Machine changes
introduced which were missed to capture the usage events
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26168/#review56384
-----------------------------------------------------------
Ship it!
Commit 50185b7c3a1fd26e9a8635c28cee70fda32d3fc5
- Kishan Kavala
On Oct. 9, 2014, 11:56 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26168/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 11:56 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala and Koushik Das.
>
>
> Bugs: CLOUDSTACK-7648
> https://issues.apache.org/jira/browse/CLOUDSTACK-7648
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There are new VM State Machine changes introduced while adding VM Sync changes and these were missed to capture the usage events.
>
> This is causing to get wrong usage statistics for a VM who's state is changed by VM sync
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/VirtualMachine.java 34387eb
> engine/components-api/src/com/cloud/network/NetworkStateListener.java c86f782
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java 92163ea
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java c998e3b
> server/src/com/cloud/capacity/CapacityManagerImpl.java e5b7d19
> server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java a40a7d7
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 968c538
> server/src/com/cloud/network/security/SecurityGroupManagerImpl.java f60a746
> server/src/com/cloud/storage/listener/SnapshotStateListener.java 8da71a6
> server/src/com/cloud/storage/listener/VolumeStateListener.java 1911a48
> server/src/com/cloud/vm/UserVmStateListener.java a0088b8
> server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java 8e606ca
> utils/src/com/cloud/utils/fsm/StateListener.java 3d0a645
> utils/src/com/cloud/utils/fsm/StateMachine2.java 4950a25cb
>
> Diff: https://reviews.apache.org/r/26168/diff/
>
>
> Testing
> -------
>
> Tested on Simulator for all VM Lifecycle states and tested with Xenserver for VM Sync reatled actions.
>
> Ran Simulator for VM lifecycle realted tests.
>
> Currenly there is no API call listUsageEvents to verify that events are generated.
>
> Ran Simulator and used smoke tests against simulator to test it.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
RE: Review Request 26168: There are new VM State Machine changes
introduced which were missed to capture the usage events
Posted by Koushik Das <ko...@citrix.com>.
Somehow the review comments are not showing?
1. Would it make sense to make the pre/post method signature identical?
2. In StateEntry.addTransition(), do you need E and S as separate parameters?
From: Koushik Das [mailto:noreply@reviews.apache.org] On Behalf Of Koushik Das
Sent: Thursday, 9 October 2014 3:00 PM
To: Kishan Kavala; Koushik Das
Cc: Damoder Reddy; cloudstack
Subject: Re: Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26168/
- Koushik Das
On October 9th, 2014, 6:26 a.m. UTC, Damodar Reddy Talakanti wrote:
Review request for cloudstack, Kishan Kavala and Koushik Das.
By Damodar Reddy Talakanti.
Updated Oct. 9, 2014, 6:26 a.m.
Bugs: CLOUDSTACK-7648<https://issues.apache.org/jira/browse/CLOUDSTACK-7648>
Repository: cloudstack-git
Description
There are new VM State Machine changes introduced while adding VM Sync changes and these were missed to capture the usage events.
This is causing to get wrong usage statistics for a VM who's state is changed by VM sync
Testing
Tested on Simulator for all VM Lifecycle states and tested with Xenserver for VM Sync reatled actions.
Ran Simulator for VM lifecycle realted tests.
Currenly there is no API call listUsageEvents to verify that events are generated.
Ran Simulator and used smoke tests against simulator to test it.
Diffs
* api/src/com/cloud/vm/VirtualMachine.java (34387eb)
* engine/components-api/src/com/cloud/network/NetworkStateListener.java (c86f782)
* plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java (92163ea)
* plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java (c998e3b)
* server/src/com/cloud/capacity/CapacityManagerImpl.java (e5b7d19)
* server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java (a40a7d7)
* server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java (968c538)
* server/src/com/cloud/network/security/SecurityGroupManagerImpl.java (f60a746)
* server/src/com/cloud/storage/listener/SnapshotStateListener.java (8da71a6)
* server/src/com/cloud/storage/listener/VolumeStateListener.java (1911a48)
* server/src/com/cloud/vm/UserVmStateListener.java (a0088b8)
* server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java (8e606ca)
* utils/src/com/cloud/utils/fsm/StateListener.java (3d0a645)
* utils/src/com/cloud/utils/fsm/StateMachine2.java (4950a25cb)
View Diff<https://reviews.apache.org/r/26168/diff/>
Re: Review Request 26168: There are new VM State Machine changes
introduced which were missed to capture the usage events
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26168/#review55964
-----------------------------------------------------------
- Koushik Das
On Oct. 9, 2014, 6:26 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26168/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 6:26 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala and Koushik Das.
>
>
> Bugs: CLOUDSTACK-7648
> https://issues.apache.org/jira/browse/CLOUDSTACK-7648
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There are new VM State Machine changes introduced while adding VM Sync changes and these were missed to capture the usage events.
>
> This is causing to get wrong usage statistics for a VM who's state is changed by VM sync
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/VirtualMachine.java 34387eb
> engine/components-api/src/com/cloud/network/NetworkStateListener.java c86f782
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java 92163ea
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java c998e3b
> server/src/com/cloud/capacity/CapacityManagerImpl.java e5b7d19
> server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java a40a7d7
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 968c538
> server/src/com/cloud/network/security/SecurityGroupManagerImpl.java f60a746
> server/src/com/cloud/storage/listener/SnapshotStateListener.java 8da71a6
> server/src/com/cloud/storage/listener/VolumeStateListener.java 1911a48
> server/src/com/cloud/vm/UserVmStateListener.java a0088b8
> server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java 8e606ca
> utils/src/com/cloud/utils/fsm/StateListener.java 3d0a645
> utils/src/com/cloud/utils/fsm/StateMachine2.java 4950a25cb
>
> Diff: https://reviews.apache.org/r/26168/diff/
>
>
> Testing
> -------
>
> Tested on Simulator for all VM Lifecycle states and tested with Xenserver for VM Sync reatled actions.
>
> Ran Simulator for VM lifecycle realted tests.
>
> Currenly there is no API call listUsageEvents to verify that events are generated.
>
> Ran Simulator and used smoke tests against simulator to test it.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 26168: There are new VM State Machine changes
introduced which were missed to capture the usage events
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26168/
-----------------------------------------------------------
(Updated Oct. 9, 2014, 6:26 a.m.)
Review request for cloudstack, Kishan Kavala and Koushik Das.
Changes
-------
removed TODO tags which are added during fix
Bugs: CLOUDSTACK-7648
https://issues.apache.org/jira/browse/CLOUDSTACK-7648
Repository: cloudstack-git
Description
-------
There are new VM State Machine changes introduced while adding VM Sync changes and these were missed to capture the usage events.
This is causing to get wrong usage statistics for a VM who's state is changed by VM sync
Diffs (updated)
-----
api/src/com/cloud/vm/VirtualMachine.java 34387eb
engine/components-api/src/com/cloud/network/NetworkStateListener.java c86f782
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java 92163ea
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java c998e3b
server/src/com/cloud/capacity/CapacityManagerImpl.java e5b7d19
server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java a40a7d7
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 968c538
server/src/com/cloud/network/security/SecurityGroupManagerImpl.java f60a746
server/src/com/cloud/storage/listener/SnapshotStateListener.java 8da71a6
server/src/com/cloud/storage/listener/VolumeStateListener.java 1911a48
server/src/com/cloud/vm/UserVmStateListener.java a0088b8
server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java 8e606ca
utils/src/com/cloud/utils/fsm/StateListener.java 3d0a645
utils/src/com/cloud/utils/fsm/StateMachine2.java 4950a25cb
Diff: https://reviews.apache.org/r/26168/diff/
Testing (updated)
-------
Tested on Simulator for all VM Lifecycle states and tested with Xenserver for VM Sync reatled actions.
Ran Simulator for VM lifecycle realted tests.
Currenly there is no API call listUsageEvents to verify that events are generated.
Ran Simulator and used smoke tests against simulator to test it.
Thanks,
Damodar Reddy Talakanti
Re: Review Request 26168: There are new VM State Machine changes
introduced which were missed to capture the usage events
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26168/
-----------------------------------------------------------
(Updated Oct. 9, 2014, 5:37 a.m.)
Review request for cloudstack, Kishan Kavala and Koushik Das.
Bugs: CLOUDSTACK-7648
https://issues.apache.org/jira/browse/CLOUDSTACK-7648
Repository: cloudstack-git
Description
-------
There are new VM State Machine changes introduced while adding VM Sync changes and these were missed to capture the usage events.
This is causing to get wrong usage statistics for a VM who's state is changed by VM sync
Diffs
-----
api/src/com/cloud/vm/VirtualMachine.java 34387eb
engine/components-api/src/com/cloud/network/NetworkStateListener.java c86f782
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java 92163ea
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java c998e3b
server/src/com/cloud/capacity/CapacityManagerImpl.java e5b7d19
server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java a40a7d7
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 968c538
server/src/com/cloud/network/security/SecurityGroupManagerImpl.java f60a746
server/src/com/cloud/storage/listener/SnapshotStateListener.java 8da71a6
server/src/com/cloud/storage/listener/VolumeStateListener.java 1911a48
server/src/com/cloud/vm/UserVmStateListener.java a0088b8
server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java 8e606ca
utils/src/com/cloud/utils/fsm/StateListener.java 3d0a645
utils/src/com/cloud/utils/fsm/StateMachine2.java 4950a25cb
Diff: https://reviews.apache.org/r/26168/diff/
Testing
-------
Tested on Simulator for all VM Lifecycle states and tested with Xenserver for VM Sync reatled actions.
Ran Simulator for VM lifecycle realted tests.
Currenly there is no API call listUsageEvents to verify that events are generated.
Thanks,
Damodar Reddy Talakanti