[GitHub] [hadoop] goiri commented on a change in pull request #3635: HDFS-16310. RBF: Add client port to CallerContext for Router

[GitBox <gi...@apache.org>]

goiri commented on a change in pull request #3635:
URL: https://github.com/apache/hadoop/pull/3635#discussion_r745844503



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
##########
@@ -228,6 +228,26 @@ public Builder append(String key, String value) {
       return this;
     }
 
+    /**
+     * Append new field which contains key and value to the context
+     * if the key("key:") is absent.
+     * @param key the key of field.
+     * @param value the value of field.
+     * @return the builder.
+     */
+    public Builder appendIfAbsent(String key, String value) {

Review comment:
       As this is pretty core; I would prefer to do the changes to commons in a HADOOP JIRA.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org