[jira] [Commented] (TINKERPOP-1185) Gremlin Console should only load/instantiate configured plugins

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230962#comment-15230962 ] 

ASF GitHub Bot commented on TINKERPOP-1185:
-------------------------------------------

Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/245#issuecomment-207068865
  
    I don't think there are any easy solutions here. I'll comment in more detail in JIRA but I'm not seeing how this gets done without considerable change to our approach to plugins. As long as we use `ServiceLoader` and require an instance of a plugin its going to load things that are inactive. I think we should probably just close this PR.


> Gremlin Console should only load/instantiate configured plugins
> ---------------------------------------------------------------
>
>                 Key: TINKERPOP-1185
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1185
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: console
>    Affects Versions: 3.1.1-incubating
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>
> Currently, gremlin-console will load and instantiate any GremlinPlugins on the classpath. It should only load and instantiate the plugins configured in plugins.txt



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)