[GitHub] [solr] stillalex commented on a diff in pull request #1943: SOLR-16960 Tests should sometimes run with a Tracer (not no-op)

["stillalex (via GitHub)" <gi...@apache.org>]

stillalex commented on code in PR #1943:
URL: https://github.com/apache/solr/pull/1943#discussion_r1332259553


##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -1299,5 +1301,15 @@ public Builder withTraceIdGenerationDisabled() {
       this.disableTraceIdGeneration = true;
       return this;
     }
+
+    /**
+     * It only makes sense to call this if we are using the alwaysOn tracer. this will randomize the
+     * Span::isRecording check for the alwaysOn tracer so we have coverage of all methods that deal
+     * with span creation without having to enable otel module
+     */
+    private void injectRandomRecordingFlag() {
+      boolean isRecording = LuceneTestCase.random().nextBoolean();

Review Comment:
   good suggestion. will move to rarely()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org