You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by dthaluru <gi...@git.apache.org> on 2016/10/14 07:15:12 UTC

[GitHub] thrift pull request #1114: Added Nonblocking SSL java client

GitHub user dthaluru opened a pull request:

    https://github.com/apache/thrift/pull/1114

    Added Nonblocking SSL java client

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dthaluru/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1114
    
----
commit c6c85090ebe32f26f97a3adbc76e3b01a9e7ceca
Author: dthaluru <dt...@vmware.com>
Date:   2016-10-14T06:52:17Z

    Added Nonblocking SSL java client

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1114: Added Nonblocking SSL java client

Posted by dthaluru <gi...@git.apache.org>.

Github user dthaluru closed the pull request at:

    https://github.com/apache/thrift/pull/1114


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1114: Added Nonblocking SSL java client

Posted by dthaluru <gi...@git.apache.org>.

Github user dthaluru commented on the issue:

    https://github.com/apache/thrift/pull/1114
  
    Thanks for your replies. Sorry, I  will send update pull request soon. I can close pull request for now and will send again later.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1114: Added Nonblocking SSL java client

Posted by nsuke <gi...@git.apache.org>.

Github user nsuke commented on the issue:

    https://github.com/apache/thrift/pull/1114
  
    @dthaluru I think we can avoid duplicating the entire client stack.
    As far as I can see the only thing that really matters is `TNonblockingSSLSocket`.
    If we make it compatible with `TNonblockingTransport`, almost anything else would not be needed any longer.
    
    The most significant incompatibility is `int read(ByteBuffer)` v.s. `ByteBuffer read(int)`.
    Would it be possible for `TNonblockingSSLSocket` to accept and reuse `ByteBuffer` so that the method signature can be the same ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---