You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "no1wudi (via GitHub)" <gi...@apache.org> on 2023/03/03 01:44:26 UTC

[GitHub] [nuttx] no1wudi commented on a diff in pull request #8691: drivers/serial: Echo input in driver layer

no1wudi commented on code in PR #8691:
URL: https://github.com/apache/nuttx/pull/8691#discussion_r1123947648


##########
drivers/serial/serial.c:
##########
@@ -886,6 +888,53 @@ static ssize_t uart_read(FAR struct file *filep,
 
           *buffer++ = ch;
           recvd++;
+
+          if (dev->isconsole
+#ifdef CONFIG_SERIAL_TERMIOS
+              && (dev->tc_iflag & ECHO)

Review Comment:
   Why? What if `dev->isconsole` is false and ECHO not set?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org