You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by TheRealHaui <gi...@git.apache.org> on 2017/07/19 15:14:24 UTC
[GitHub] commons-imaging pull request #29: Improve various unit tests style
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-imaging/pull/29
Improve various unit tests style
Code formatting changed as desired in #27 and #28.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TheRealHaui/commons-imaging improve-various-unit-tests-style
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-imaging/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit 5c8b1fcf92fdab412818b20175c617e3690fc060
Author: Michael Hausegger <ha...@googlemail.com>
Date: 2017-07-13T20:12:46Z
increase-code-coverage-one Added Unit Tests to increase code coverage.
commit 471ac19d179a3eb167930f163117703cf7851aa8
Author: Michael Hausegger <ha...@googlemail.com>
Date: 2017-07-13T21:00:31Z
increase-code-coverage-one Added Unit Tests to increase code coverage.
commit ff9adf8a87c3963dcc5a0f0be9668f1690f8fd45
Author: Michael Hausegger <ha...@googlemail.com>
Date: 2017-07-13T21:14:08Z
increase-code-coverage-one Fixed failing test.
commit 489c8c33ad03e9f22762e0520670694f08659c57
Author: Michael Hausegger <ha...@googlemail.com>
Date: 2017-07-15T21:39:54Z
increase-code-coverage-one Fix directory hierarchy problem.
commit d0c70bddfbeff23970702b339de938d6d2876d33
Author: Michael Hausegger <ha...@googlemail.com>
Date: 2017-07-19T14:18:07Z
improve-various-unit-tests-style Improved code formatting.
commit 2e962d12698711f3614fe16ff75036c139d4d1fb
Author: Michael Hausegger <ha...@googlemail.com>
Date: 2017-07-19T14:40:55Z
improve-various-unit-tests-style Changed various blank lines and blanks as requested.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-imaging issue #29: Improve various unit tests style
Posted by jbduncan <gi...@git.apache.org>.
Github user jbduncan commented on the issue:
https://github.com/apache/commons-imaging/pull/29
Looks much better, thanks @TheRealHaui!
As I discussed in #28, I'm sure there's area for improvement on the whitespace/readability front, but that would require running `mvn checkstyle:check` and fixing the warnings it reports in a separate PR.
On a related note, Travis seems to complaining that GreyScaleRountripTest (unrelated to this PR AFAICT) killed the JVM process during testing. Perhaps Travis just needs to be restarted and the test will run properly? But I don't immediately know how one would restart Travis...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-imaging issue #29: Improve various unit tests style
Posted by TheRealHaui <gi...@git.apache.org>.
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-imaging/pull/29
You're welcome.
However, have to get used to the importance of style topics yet ...
Regarding the GreyScaleRoundTripTest:
Yes.
However, I thing or better guess it has to do with the amount of memory the Travis instance got supplied with.
As its a free service I'd await it to have very less memory.
And the specific test needs on my local machine quit a lot of memory as there is a JUnit theory inside.
Therefore I guess a restart won't help.
However again, I can only guess and I'am sure only owners can play around with CI instance settings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-imaging pull request #29: Improve various unit tests style
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-imaging/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org