You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "SvenRoederer (via GitHub)" <gi...@apache.org> on 2024/07/06 04:22:29 UTC
[PR] CI bump versions of GitHubActions and Ubuntu [thrift]
SvenRoederer opened a new pull request, #2994:
URL: https://github.com/apache/thrift/pull/2994
upgrade artifact-actions from v3 to v4
* v3 uses Node.js 16, which is deprecated and causes warning messages
* < v4 will get deprecated in Nov 2024 (https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/)
switch to ubuntu-22.04 by default
* Ubuntu 20.04 will go EoL in Aril 2025
* build the compiler on ubuntu-24.04, ubuntu-22.04 and ubuntu-20.04
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CI bump versions of GitHubActions and Ubuntu [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #2994:
URL: https://github.com/apache/thrift/pull/2994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CI bump versions of GitHubActions and Ubuntu [thrift]
Posted by "jimexist (via GitHub)" <gi...@apache.org>.
jimexist commented on PR #2994:
URL: https://github.com/apache/thrift/pull/2994#issuecomment-2213044807
how about just dropping 20.04?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CI bump versions of GitHubActions and Ubuntu [thrift]
Posted by "SvenRoederer (via GitHub)" <gi...@apache.org>.
SvenRoederer commented on PR #2994:
URL: https://github.com/apache/thrift/pull/2994#issuecomment-2213757241
To keep building compiler with ubuntu -20.04, as long a the image can be uses, and have the compiler build with ubuntu-{20|22|24}.04 in parallel was also my intention.
For #2993 (syntax-error in deepcopy() for 0.20.0) I made the code based on this branch. When this code will be accepted, I can rebase it into 2 commits just on top of master, to have a nice linear history.
regarding docker images as mentioned by @sveneld: I'm not this deep into docker, that I can setup a test-env quickly. I can for sure copy code from existing images and keep fingers crossed. I there a place where I can see CI-logs that use these docker-images?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CI bump versions of GitHubActions and Ubuntu [thrift]
Posted by "sveneld (via GitHub)" <gi...@apache.org>.
sveneld commented on PR #2994:
URL: https://github.com/apache/thrift/pull/2994#issuecomment-2213135178
Ubuntu 20.04 is still active, my opinion is we can remove its support only after EOL.
And I suggest you add support for Ubuntu 24.04 instead of removing support for Ubuntu 20.04
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CI bump versions of GitHubActions and Ubuntu [thrift]
Posted by "sveneld (via GitHub)" <gi...@apache.org>.
sveneld commented on PR #2994:
URL: https://github.com/apache/thrift/pull/2994#issuecomment-2211691310
It will be great to add a dockerFile for Ubuntu 24.04 in folder build/docker, not just in github actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org