You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2019/01/12 06:50:44 UTC

[GitHub] felixcheung commented on a change in pull request #3179: [ZEPPELIN-3773] - add check permission on write.

felixcheung commented on a change in pull request #3179: [ZEPPELIN-3773] - add check permission on write.
URL: https://github.com/apache/zeppelin/pull/3179#discussion_r247303885
 
 

 ##########
 File path: zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
 ##########
 @@ -759,6 +759,9 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, $routeParams, $locat
   };
 
   $scope.sendPatch = function() {
+    if (!$scope.userHasWritePermission()) {
 
 Review comment:
   should this save $scope.userHasWritePermission() and not called it multiple times?
   what if the return from `$scope.userHasWritePermission()` changes?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services